Skip to content

chore(deps): update dependency @patternfly/react-core to v6.6.1 - #188

Open
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/patternfly-react-core-6.x
Open

chore(deps): update dependency @patternfly/react-core to v6.6.1#188
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/patternfly-react-core-6.x

Conversation

@red-hat-konflux

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
@patternfly/react-core 6.6.06.6.1 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

patternfly/patternfly-react (@​patternfly/react-core)

v6.6.1

Compare Source


Configuration

📅 Schedule: (in timezone America/New_York)

  • Branch creation
    • Between 12:00 AM and 07:59 AM, only on Monday (* 0-7 * * 1)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
[ERR_PNPM_UNSUPPORTED_ENGINE] Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/tmp/renovate/repos/github/openshift-online/hypershell".

Expected version: >=24.18.1
Got: v24.11.0

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 58990b27-6ddd-49bd-8961-8a099e0a2825

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@jsell-rh

jsell-rh commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Amber review

Status: Complete

Verdict

COMMENT (recommend changes before merge). This is a low-risk Renovate patch bump of @patternfly/react-core 6.6.0 -> 6.6.1, but it only updates the peerDependencies entry and leaves the package's own devDependency and the consuming web-console at 6.6.0, creating a PatternFly version split across the stack that should be resolved before merge.

Hi, Amber here. I reviewed the single-line dependency change against the HyperShell conventions (notably "image/dependency references must match across the stack") and cross-checked the other open PRs for coordination issues.

Summary

The change itself is a valid conventional-commit patch bump and carries little functional risk for a PatternFly patch release. My concern is consistency: @patternfly/react-core is now declared at two different versions inside the same package.json, its sibling PatternFly packages stay at 6.6.0, and the only consumer (web-console) still provides 6.6.0, so the newly-declared peer requirement is not actually satisfied anywhere in the workspace.

Findings

[Major] Intra-package version split for @patternfly/react-corepeerDependencies was bumped to 6.6.1 (line 24) but devDependencies still pins 6.6.0 (line 36). The package is therefore built and tested against 6.6.0 while declaring it needs 6.6.1 from consumers. These two entries should move together. Convention: dependency references must match across the stack. Confidence: High.

[Major] Consumer web-console still provides 6.6.0 -> unmet peercomponents/web-console/package.json:34 pins @patternfly/react-core: 6.6.0. Because the peer requirement here is an exact pin (6.6.1), the sole workspace consumer no longer satisfies it, which will surface as an unmet-peer warning/resolution mismatch. Either bump the consumer too or land this with the coordinated set (see Cross-PR section). Confidence: Medium-High.

[Minor] Sibling PatternFly packages left out of lockstep@patternfly/react-icons and @patternfly/react-table remain 6.6.0 in both peerDependencies and devDependencies. PatternFly expects @patternfly/* to be installed at matching versions; mixing 6.6.1 core with 6.6.0 icons/table is usually fine within a patch line but is best kept in lockstep. Confidence: Medium.

[Info] Lockfile unchangedpnpm-lock.yaml still records 6.6.0. pnpm does not enumerate peerDependencies in importer snapshots, so a frozen-lockfile install is unlikely to break from this change alone; I mention it only so a maintainer can confirm CI stays green. Confidence: Low.

Cross-PR coordination

I compared this PR against the other open PRs in openshift-online/hypershell. Open PRs at review time: #216, #214, #212, #211, #210, #209, #208, #207, #206, #201, #200, #194, #189, #188 (this PR), #185, #182, #179, #151, #150, #148, #135, #109, #75, #73.

No material cross-PR conflict beyond the #189 lockstep coordination above.

Recommended action

Update devDependencies @patternfly/react-core to 6.6.1 in this same file, and coordinate with #189 (and a react-table bump + the web-console consumer pin) so the entire PatternFly family lands at 6.6.1 together. Rollback is trivial: revert this one-line change.

Findings Summary (ordered by severity, highest first):

  1. [Major] @patternfly/react-core split across peerDependencies (6.6.1) and devDependencies (6.6.0) - Dependency Consistency (L24, L36)
  2. [Major] Consumer web-console still pins 6.6.0, leaving the new exact peer requirement unsatisfied - Dependency Consistency (components/web-console/package.json:34)
  3. [Minor] Sibling @patternfly/react-icons / @patternfly/react-table left at 6.6.0, breaking PatternFly lockstep - Dependency Consistency (L25-26)
  4. [Info] pnpm-lock.yaml unchanged; confirm frozen-lockfile CI stays green - Build Hygiene

Convention Checklist:

Convention Result
Conventional commit message Pass
Dependency references match across the stack Fail
Config separate from code Pass
No secrets in logs/responses N/A (no code change)

@jsell-rh jsell-rh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

COMMENT (recommend changes before merge). This is a low-risk Renovate patch bump of @patternfly/react-core 6.6.0 -> 6.6.1, but it only updates the peerDependencies entry and leaves the package's own devDependency and the consuming web-console at 6.6.0, creating a PatternFly version split across the stack that should be resolved before merge.

Hi, Amber here. I reviewed the single-line dependency change against the HyperShell conventions (notably "image/dependency references must match across the stack") and cross-checked the other open PRs for coordination issues.

Summary

The change itself is a valid conventional-commit patch bump and carries little functional risk for a PatternFly patch release. My concern is consistency: @patternfly/react-core is now declared at two different versions inside the same package.json, its sibling PatternFly packages stay at 6.6.0, and the only consumer (web-console) still provides 6.6.0, so the newly-declared peer requirement is not actually satisfied anywhere in the workspace.

Findings

[Major] Intra-package version split for @patternfly/react-corepeerDependencies was bumped to 6.6.1 (line 24) but devDependencies still pins 6.6.0 (line 36). The package is therefore built and tested against 6.6.0 while declaring it needs 6.6.1 from consumers. These two entries should move together. Convention: dependency references must match across the stack. Confidence: High.

[Major] Consumer web-console still provides 6.6.0 -> unmet peercomponents/web-console/package.json:34 pins @patternfly/react-core: 6.6.0. Because the peer requirement here is an exact pin (6.6.1), the sole workspace consumer no longer satisfies it, which will surface as an unmet-peer warning/resolution mismatch. Either bump the consumer too or land this with the coordinated set (see Cross-PR section). Confidence: Medium-High.

[Minor] Sibling PatternFly packages left out of lockstep@patternfly/react-icons and @patternfly/react-table remain 6.6.0 in both peerDependencies and devDependencies. PatternFly expects @patternfly/* to be installed at matching versions; mixing 6.6.1 core with 6.6.0 icons/table is usually fine within a patch line but is best kept in lockstep. Confidence: Medium.

[Info] Lockfile unchangedpnpm-lock.yaml still records 6.6.0. pnpm does not enumerate peerDependencies in importer snapshots, so a frozen-lockfile install is unlikely to break from this change alone; I mention it only so a maintainer can confirm CI stays green. Confidence: Low.

Cross-PR coordination

I compared this PR against the other open PRs in openshift-online/hypershell. Open PRs at review time: #216, #214, #212, #211, #210, #209, #208, #207, #206, #201, #200, #194, #189, #188 (this PR), #185, #182, #179, #151, #150, #148, #135, #109, #75, #73.

  • #189 chore(deps): update dependency @patternfly/react-icons to v6.6.1 — material coordination. #189 is a sibling PatternFly bump that edits the same file and the same peerDependencies block (packages/gateway-management-ui/package.json), moving @patternfly/react-icons 6.6.0 -> 6.6.1. Together, #188 + #189 (plus a react-table bump) constitute one lockstep PatternFly 6.6.1 upgrade. Landing #188 alone leaves the PatternFly family mismatched (core 6.6.1, icons/table 6.6.0), and neither PR touches the devDependencies or the web-console consumer. Maintainer decision needed: land these PatternFly bumps as a coordinated set (and include react-table, the devDependency, and the web-console pin) rather than piecemeal. This is a plan/ordering coordination, not merely the text merge conflict that will also occur on second merge.
  • #135 chore(deps): update dependency react-intl to v10.1.20 — no material conflict. It edits the same package.json peerDependencies block but a different, unrelated package (react-intl). The only overlap is a routine text merge on the second merge; there is no design, data-model, interface, or ordering conflict.
  • UI/web-console PRs (#216, #214, #210, #209, #208, #207) — no material conflict. These add/modify UI features that consume PatternFly but do not change its version. A PatternFly patch bump is not expected to alter public component APIs, so there is no incompatible design or competing interface change.
  • All other open PRs (control-plane, auth, e2e, images, docs, Go/container dependency bumps) touch unrelated areas with no goal, ownership, data-model, or ordering conflict with this frontend dependency bump.

No material cross-PR conflict beyond the #189 lockstep coordination above.

Recommended action

Update devDependencies @patternfly/react-core to 6.6.1 in this same file, and coordinate with #189 (and a react-table bump + the web-console consumer pin) so the entire PatternFly family lands at 6.6.1 together. Rollback is trivial: revert this one-line change.

Findings Summary (ordered by severity, highest first):

  1. [Major] @patternfly/react-core split across peerDependencies (6.6.1) and devDependencies (6.6.0) - Dependency Consistency (L24, L36)
  2. [Major] Consumer web-console still pins 6.6.0, leaving the new exact peer requirement unsatisfied - Dependency Consistency (components/web-console/package.json:34)
  3. [Minor] Sibling @patternfly/react-icons / @patternfly/react-table left at 6.6.0, breaking PatternFly lockstep - Dependency Consistency (L25-26)
  4. [Info] pnpm-lock.yaml unchanged; confirm frozen-lockfile CI stays green - Build Hygiene

Convention Checklist:

Convention Result
Conventional commit message Pass
Dependency references match across the stack Fail
Config separate from code Pass
No secrets in logs/responses N/A (no code change)

},
"peerDependencies": {
"@patternfly/react-core": "6.6.0",
"@patternfly/react-core": "6.6.1",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] Version split within this file. This peerDependencies entry is now @patternfly/react-core: 6.6.1, but the devDependencies entry (line 36) still pins 6.6.0, so the package is built/tested against 6.6.0 while declaring it needs 6.6.1 from consumers. Bump the devDependency in the same change so both match. Also note the sole consumer components/web-console/package.json:34 still provides 6.6.0, which no longer satisfies this exact peer pin. Consider landing together with #189 (react-icons 6.6.1) and a react-table bump to keep the PatternFly family in lockstep.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/patternfly-react-core-6.x branch from 7962e09 to 22d7329 Compare August 31, 2026 05:06
@jsell-rh

jsell-rh commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Amber review: changes requested

Amber review

Status: Complete

Verdict

REQUEST_CHANGES

This Renovate PR bumps only the @patternfly/react-core peerDependency in the shared gateway-management-ui package to an exact 6.6.1, but leaves the package's own devDependency and the web-console consumer at 6.6.0. With strictPeerDependencies: true and saveExact: true in pnpm-workspace.yaml, this partial bump produces an invalid (version-mismatched) peer dependency, which will fail pnpm install/check rather than emit a mere warning.

Findings

[Critical] Exact peer pin 6.6.1 is unsatisfiable by the co-located devDependency and the consumer (still 6.6.0)Dependency Integrity (packages/gateway-management-ui/package.json L24)

  • The peerDependency is now pinned to exactly 6.6.1, but:
    • the same file's devDependencies["@patternfly/react-core"] is still 6.6.0 (L36), so the package is built/tested against a version that does not satisfy its own advertised peer;
    • the only consumer, components/web-console/package.json, pins @patternfly/react-core to 6.6.0 (L34) and injects this workspace package (injectWorkspacePackages: true).
  • pnpm-workspace.yaml sets strictPeerDependencies: true. A mismatched peer (6.6.0 provided vs exact 6.6.1 required) is treated as invalid, and autoInstallPeers will not resolve a conflicting second copy when a direct provider exists at a different version. The likely result is a failing install/pnpm --filter ... check.
  • Fix: bump @patternfly/react-core to 6.6.1 in the same file's devDependencies (L36) and in components/web-console/package.json (L34) in the same change, and regenerate the lockfile if needed, so all providers match the peer requirement. Confidence: Medium-High.

[Minor] PatternFly package family left version-skewedDependency Integrity (packages/gateway-management-ui/package.json L24-26)

  • @patternfly/react-icons and @patternfly/react-table remain at 6.6.0 while react-core moves to 6.6.1. PatternFly ships these as a matched set and expects them aligned within a release; bumping only one leaves the trio skewed. Keep the three PatternFly packages on the same version. Confidence: Medium.

Cross-PR coordination

The sibling dependency bumps for @patternfly/react-icons (#189) and @patternfly/react-table (#225) each raise only their own peerDependency line in this same shared package to 6.6.1, leaving the other two PatternFly packages, the local devDependencies, and the web-console consumer at 6.6.0. Under strictPeerDependencies: true with exact pins, merging any one of these in isolation yields an intermediate state with a version-skewed PatternFly family and unsatisfiable exact peers, which breaks pnpm install. Maintainers should decide to treat #188/#189/#225 as one coordinated, version-aligned change set (including the matching devDependency and web-console consumer bumps) rather than merging them independently.

Findings Summary (ordered by severity, highest first)

  1. [Critical] Exact peer pin 6.6.1 unsatisfiable by devDependency + consumer at 6.6.0 under strictPeerDependencies - Dependency Integrity (L24, L36)
  2. [Minor] PatternFly react-icons/react-table left at 6.6.0 while react-core moves to 6.6.1 - Dependency Integrity (L24-26)

Convention Checklist

Convention Result
Conventional commit message Pass
Dependency versions aligned across peer/dev/consumer (strict peers) Fail
PatternFly package family kept on a single version Fail
Lockfile in sync with manifest (peer-only edit not tracked in importer lockfile) Pass

@jsell-rh jsell-rh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

REQUEST_CHANGES

This Renovate PR bumps only the @patternfly/react-core peerDependency in the shared gateway-management-ui package to an exact 6.6.1, but leaves the package's own devDependency and the web-console consumer at 6.6.0. With strictPeerDependencies: true and saveExact: true in pnpm-workspace.yaml, this partial bump produces an invalid (version-mismatched) peer dependency, which will fail pnpm install/check rather than emit a mere warning.

Findings

[Critical] Exact peer pin 6.6.1 is unsatisfiable by the co-located devDependency and the consumer (still 6.6.0)Dependency Integrity (packages/gateway-management-ui/package.json L24)

  • The peerDependency is now pinned to exactly 6.6.1, but:
    • the same file's devDependencies["@patternfly/react-core"] is still 6.6.0 (L36), so the package is built/tested against a version that does not satisfy its own advertised peer;
    • the only consumer, components/web-console/package.json, pins @patternfly/react-core to 6.6.0 (L34) and injects this workspace package (injectWorkspacePackages: true).
  • pnpm-workspace.yaml sets strictPeerDependencies: true. A mismatched peer (6.6.0 provided vs exact 6.6.1 required) is treated as invalid, and autoInstallPeers will not resolve a conflicting second copy when a direct provider exists at a different version. The likely result is a failing install/pnpm --filter ... check.
  • Fix: bump @patternfly/react-core to 6.6.1 in the same file's devDependencies (L36) and in components/web-console/package.json (L34) in the same change, and regenerate the lockfile if needed, so all providers match the peer requirement. Confidence: Medium-High.

[Minor] PatternFly package family left version-skewedDependency Integrity (packages/gateway-management-ui/package.json L24-26)

  • @patternfly/react-icons and @patternfly/react-table remain at 6.6.0 while react-core moves to 6.6.1. PatternFly ships these as a matched set and expects them aligned within a release; bumping only one leaves the trio skewed. Keep the three PatternFly packages on the same version. Confidence: Medium.

Cross-PR coordination

The sibling dependency bumps for @patternfly/react-icons (#189) and @patternfly/react-table (#225) each raise only their own peerDependency line in this same shared package to 6.6.1, leaving the other two PatternFly packages, the local devDependencies, and the web-console consumer at 6.6.0. Under strictPeerDependencies: true with exact pins, merging any one of these in isolation yields an intermediate state with a version-skewed PatternFly family and unsatisfiable exact peers, which breaks pnpm install. Maintainers should decide to treat #188/#189/#225 as one coordinated, version-aligned change set (including the matching devDependency and web-console consumer bumps) rather than merging them independently.

Findings Summary (ordered by severity, highest first)

  1. [Critical] Exact peer pin 6.6.1 unsatisfiable by devDependency + consumer at 6.6.0 under strictPeerDependencies - Dependency Integrity (L24, L36)
  2. [Minor] PatternFly react-icons/react-table left at 6.6.0 while react-core moves to 6.6.1 - Dependency Integrity (L24-26)

Convention Checklist

Convention Result
Conventional commit message Pass
Dependency versions aligned across peer/dev/consumer (strict peers) Fail
PatternFly package family kept on a single version Fail
Lockfile in sync with manifest (peer-only edit not tracked in importer lockfile) Pass

},
"peerDependencies": {
"@patternfly/react-core": "6.6.0",
"@patternfly/react-core": "6.6.1",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Critical] Exact peer pin unsatisfiable under strict peer resolution.

This raises the @patternfly/react-core peerDependency to an exact 6.6.1, but the same file still declares devDependencies["@patternfly/react-core"] = 6.6.0 (L36) and the only consumer, components/web-console/package.json, pins 6.6.0 (L34). With strictPeerDependencies: true and saveExact: true, a version-mismatched peer is treated as invalid and will fail pnpm install/check, not just warn.

Fix: bump the devDependency here (L36) and the web-console dependency (L34) to 6.6.1 in the same change, and align react-icons/react-table so the PatternFly family stays on one version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant