chore(deps): update dependency @patternfly/react-table to v6.6.1 - #225
chore(deps): update dependency @patternfly/react-table to v6.6.1#225red-hat-konflux[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Amber reviewStatus: Complete VerdictAssessment: COMMENT. This is a low-risk Renovate bump of the Findings[Minor] Peer version bumped in isolation from the dev/lock version — the bump is effectively not exercised. [Minor] Cross-PR coordinationTwo other open dependency updates bump the sibling PatternFly packages to the same Findings Summary (ordered by severity, highest first)
Convention Checklist
|
jsell-rh
left a comment
There was a problem hiding this comment.
Verdict
Assessment: COMMENT. This is a low-risk Renovate bump of the @patternfly/react-table peer dependency from 6.6.0 to 6.6.1 in the reusable gateway UI package, and it follows the repo's existing bot-update pattern. One consistency nuance and one cross-PR coordination point are worth a maintainer's attention before merge, but nothing here is blocking.
Findings
[Minor] Peer version bumped in isolation from the dev/lock version — the bump is effectively not exercised.
packages/gateway-management-ui/package.json L26 raises @patternfly/react-table to 6.6.1 under peerDependencies, but the same package still pins 6.6.0 under devDependencies (L38) and pnpm-lock.yaml still resolves 6.6.0 for both importer entries. As a result the package continues to be built and tested against 6.6.0 while advertising 6.6.1 to consumers, so the declared contract and the actually validated version diverge. This matches the shape of the repo's other Renovate peer-only bumps, so it is not new breakage, but it means the update has no real effect until the dev dependency and lockfile are advanced too. Confidence: High.
[Minor] @patternfly/* family drifts out of lockstep.
@patternfly/react-table@6.6.1 expects its sibling @patternfly/react-core / @patternfly/react-icons at the same version (the current lockfile shows react-table@6.6.0 pinned to react-core@6.6.0 and react-icons@6.6.0). After this change react-table is 6.6.1 while both siblings remain 6.6.0 (L24-L25), a mixed peer contract PatternFly recommends avoiding. See the Cross-PR coordination note below. Confidence: Medium.
Cross-PR coordination
Two other open dependency updates bump the sibling PatternFly packages to the same 6.6.1 target: one for @patternfly/react-core (#188) and one for @patternfly/react-icons (#189). Each of the three PRs advances exactly one @patternfly/* peer and leaves the other two at 6.6.0, so merging any one alone leaves the @patternfly/react-* family on mixed versions — which PatternFly expects to move in lockstep (the lockfile shows the 6.6.0 packages pinned to each other at the same version). Maintainers should decide to land #188, #189, and this PR together (or fold them into a single grouped update) and regenerate pnpm-lock.yaml once for the combined result, rather than merging them independently.
Findings Summary (ordered by severity, highest first)
- [Minor] Peer bumped in isolation; devDependency +
pnpm-lock.yamlstill on6.6.0, so the new version is not built/tested — Dependency consistency (package.json L26, L38) - [Minor]
@patternfly/*family left on mixed6.6.1/6.6.0versions — Dependency consistency (package.json L24-L26)
Convention Checklist
| Convention | Result |
|---|---|
| Conventional commit message | Pass |
| Dependency/version references consistent across manifest + lockfile | Fail |
| "@patternfly/react-core": "6.6.0", | ||
| "@patternfly/react-icons": "6.6.0", | ||
| "@patternfly/react-table": "6.6.0", | ||
| "@patternfly/react-table": "6.6.1", |
There was a problem hiding this comment.
The peer requirement is raised to 6.6.1 here, but devDependencies (line 38) and pnpm-lock.yaml still pin/resolve 6.6.0. So the package keeps building and testing against 6.6.0 while telling consumers to install 6.6.1 — the update is not actually exercised until the dev dependency and lockfile advance too. Also note react-table@6.6.1 expects its @patternfly/react-core/react-icons siblings (lines 24-25) at the same version; keeping them on 6.6.0 leaves the PatternFly family out of lockstep.

This PR contains the following updates:
6.6.0→6.6.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
patternfly/patternfly-react (@patternfly/react-table)
v6.6.1Compare Source
Configuration
📅 Schedule: (in timezone America/New_York)
* 0-7 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.