fix(cli): DSPX-4607 annotate deprecated Action.Value use in migration test by dmihalcik-virtru · Pull Request #3969 · opentdf/platform

dmihalcik-virtru · 2026-09-03T19:49:10Z

Part of the DSPX-4607 lint burndown, following the golangci-lint v2.13.2 bump (#3965, merged). Branched from main, independent of the other burndown PRs.

Best merged after #3968 (goconst tuning), which clears the other 133 otdfctl findings.

What

golangci-lint v2.13.2 reports one SA1019 in otdfctl:

otdfctl/migrations/namespacedpolicy/resolved_test.go:343:7: SA1019: (policy.Action).Value is deprecated: use 'name' instead (staticcheck)

TestResolveExisting… constructs a policy.Action whose Id is literally "legacy" and deliberately sets the deprecated Value oneof so the resolver takes the standard-action path — see the comment two blocks up: "entirely on the proto Standard enum to reach the standard-action path". Migrating it to Name would delete the behaviour the test exists to cover, so it's annotated instead.

Testing

$ cd otdfctl && golangci-lint run -c ../.golangci.yaml
0 issues.
$ go test ./migrations/...
ok  	github.com/opentdf/platform/otdfctl/migrations/namespacedpolicy	0.602s

(run against the tuned config from #3968; otdfctl goes from 134 findings to 0 across the two PRs)

Summary by CodeRabbit

Tests
- Improved test clarity by documenting intentional coverage of a legacy action path.
- Reformatted test data for consistency; test behavior and assertions remain unchanged.

DSPX-4607 burndown index

chore(ci): DSPX-4607 bump golangci-lint to v2.13.2 #3965 — golangci-lint v2.13.2 bump (merged)
chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968 — .golangci.yaml goconst tuning + gomodguard_v2 migration (merged)
Siblings: fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake #3970 (service/kas), chore(core): DSPX-4607 drop stale lib/fixtures nolint directives and reuse keycloakBoolTrue #3971 (lib/fixtures), fix(sdk): DSPX-4607 canonicalize DPoP headers and extract zipstream constants #3973 (sdk), fix(examples): DSPX-4607 clear goconst and SA1019 lint findings #3974 (examples), fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975 (tests-bdd), fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977 (service/policy), fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978 (service core)

coderabbitai · 2026-09-03T19:49:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: ebdc8572-5e0d-45db-8ac2-8637364417f4

📥 Commits

Reviewing files that changed from the base of the PR and between 3052b2a and 4b08b25.

📒 Files selected for processing (1)

otdfctl/migrations/namespacedpolicy/resolved_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The change documents intentional use of the deprecated policy.Action.Value field in an existing test. It also realigns literal fields. Test behavior and assertions remain unchanged.

Changes

Legacy action test coverage

Layer / File(s)	Summary
Document deprecated action usage `otdfctl/migrations/namespacedpolicy/resolved_test.go`	The existing `policy.Action` literal adds a `//nolint:staticcheck` comment for deliberate legacy-field usage. Field alignment is also adjusted.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c5cd9

This change documents intentional legacy action coverage in a migration test without changing runtime behavior or assertions. No current merge-blocking risk remains.

Suggested reviewers: alkalescent

Poem

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: annotating the intentionally deprecated `policy.Action.Value` usage in a migration test.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/lint-otdfctl-sa1019

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-03T19:55:09Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	194.094045ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	102.529906ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	419.281048ms
Throughput	238.50 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	53.570650592s
Average Latency	534.503898ms
Throughput	93.33 requests/second

github-actions · 2026-09-03T20:05:58Z

X-Test Results

✅ go@main-v0.9.0
✅ go@pull-3969-main
✅ go@pull-3969-pull-3969
bats-test-results
✅ go@pull-3969-v0.9.0
cukes-report
✅ go@main-main
✅ java@main-pull-3969
✅ js@main-main
✅ java@main-main
✅ go@main-pull-3969
✅ java@main-v0.9.0
✅ js@main-pull-3969
✅ js@main-v0.9.0
opentdf~~platform~~WPY31X.dockerbuild
govulncheck-failure-8
govulncheck-failure-1
govulncheck-failure-3

github-actions · 2026-09-03T21:45:35Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	172.919255ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	86.410753ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	294.842094ms
Throughput	339.16 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	42.956859609s
Average Latency	428.748351ms
Throughput	116.40 requests/second

github-actions · 2026-09-03T21:55:59Z

X-Test Results

✅ js@main-pull-3969
bats-test-results
✅ go@pull-3969-main
✅ go@main-main
✅ go@main-pull-3969
✅ go@main-v0.9.0
✅ go@pull-3969-v0.9.0
cukes-report
✅ java@main-main
✅ go@pull-3969-pull-3969
✅ java@main-pull-3969
✅ js@main-main
✅ java@main-v0.9.0
✅ js@main-v0.9.0
opentdf~~platform~~CT5HX4.dockerbuild

… test golangci-lint v2.13.2 reports SA1019 for the deprecated policy.Action.Value oneof. This test deliberately exercises the legacy standard-action path, so annotate rather than migrate. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>

Invalidated by push of c5cd9ef

github-actions · 2026-09-04T13:19:38Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	229.987484ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	125.207099ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	441.924552ms
Throughput	226.28 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	56.060945575s
Average Latency	559.128075ms
Throughput	89.19 requests/second

github-actions · 2026-09-04T13:21:29Z

X-Test Failure Report

opentdf~~platform~~8CZ869.dockerbuild
govulncheck-failure-3
govulncheck-failure-8
govulncheck-failure-1

github-actions · 2026-09-04T13:27:29Z

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

otdfctl
service
tests-bdd

See the workflow run for details.

github-actions · 2026-09-04T13:52:12Z

X-Test Results

✅ go@pull-3969-main
✅ go@main-main
✅ go@main-pull-3969
✅ go@pull-3969-pull-3969
✅ go@pull-3969-v0.9.0
✅ js@main-main
✅ java@main-main
✅ js@main-v0.9.0
✅ java@main-v0.9.0
✅ go@main-v0.9.0
✅ java@main-pull-3969
✅ js@main-pull-3969
bats-test-results
cukes-report
opentdf~~platform~~8CZ869.dockerbuild
govulncheck-failure-3
govulncheck-failure-8
govulncheck-failure-1

dmihalcik-virtru requested a review from a team as a code owner September 3, 2026 19:49

github-actions Bot added the size/xs label Sep 3, 2026

dmihalcik-virtru force-pushed the fix/lint-otdfctl-sa1019 branch from a22ca22 to 4b08b25 Compare September 3, 2026 21:39

dmihalcik-virtru mentioned this pull request Sep 3, 2026

chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968

Merged

This was referenced Sep 3, 2026

fix(examples): DSPX-4607 clear goconst and SA1019 lint findings #3974

Open

fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975

Open

jakedoublev previously approved these changes Sep 3, 2026

View reviewed changes

This was referenced Sep 4, 2026

fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977

Open

fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978

Open

dmihalcik-virtru force-pushed the fix/lint-otdfctl-sa1019 branch from 4b08b25 to c5cd9ef Compare September 4, 2026 13:13

Uh oh!

Conversation

dmihalcik-virtru commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Testing

Summary by CodeRabbit

DSPX-4607 burndown index

Uh oh!

coderabbitai Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 3, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 3, 2026

X-Test Results

Uh oh!

github-actions Bot commented Sep 3, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 3, 2026

X-Test Results

Uh oh!

github-actions Bot commented Sep 4, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 4, 2026

X-Test Failure Report

Uh oh!

github-actions Bot commented Sep 4, 2026

⚠️ Govulncheck found vulnerabilities ⚠️

Uh oh!

github-actions Bot commented Sep 4, 2026

X-Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dmihalcik-virtru commented Sep 3, 2026 •

edited

Loading

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading