fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake by dmihalcik-virtru · Pull Request #3970 · opentdf/platform

dmihalcik-virtru · 2026-09-03T19:50:14Z

Part of the DSPX-4607 lint burndown, following the golangci-lint v2.13.2 bump (#3965, merged). Branched from main, independent of the other burndown PRs.

What

golangci-lint v2.13.2 enforces sloglint's key-naming-case: snake, which was configured but not previously reachable. service/kas has exactly one violation:

service/kas/access/rewrap_test.go:79:15: keys should be written in snake_case (sloglint)

"Indexer" → "indexer" on the fakeKeyIndex.LogValue group. Test-only fake, no emitted-log contract.

The identical pattern in service/trust/delegating_key_service_test.go:67 is renamed the same way in the service core PR — different CODEOWNER group, so it can't ride along here.

Testing

$ cd service && golangci-lint run -c ../.golangci.yaml ./kas/...
0 issues.
$ go test ./kas/...
ok  	github.com/opentdf/platform/service/kas		0.511s
ok  	github.com/opentdf/platform/service/kas/access	0.761s

DSPX-4607 burndown index

chore(ci): DSPX-4607 bump golangci-lint to v2.13.2 #3965 — golangci-lint v2.13.2 bump (merged)
chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968 — .golangci.yaml goconst tuning + gomodguard_v2 migration (merged)
Siblings: fix(cli): DSPX-4607 annotate deprecated Action.Value use in migration test #3969 (otdfctl), chore(core): DSPX-4607 drop stale lib/fixtures nolint directives and reuse keycloakBoolTrue #3971 (lib/fixtures), fix(sdk): DSPX-4607 canonicalize DPoP headers and extract zipstream constants #3973 (sdk), fix(examples): DSPX-4607 clear goconst and SA1019 lint findings #3974 (examples), fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975 (tests-bdd), fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977 (service/policy), fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978 (service core)

coderabbitai · 2026-09-03T19:50:26Z

Warning

Review limit reached

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: d1a7d53b-eff6-4010-ba53-ace24c1038fb

📥 Commits

Reviewing files that changed from the base of the PR and between d5933ed and 50230b1.

📒 Files selected for processing (1)

service/kas/access/rewrap_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-03T19:57:10Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	239.685912ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	122.443299ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	451.967901ms
Throughput	221.25 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	56.954384938s
Average Latency	568.211321ms
Throughput	87.79 requests/second

github-actions · 2026-09-03T20:06:14Z

X-Test Results

✅ go@main-pull-3970
bats-test-results
✅ go@pull-3970-pull-3970
✅ go@pull-3970-main
✅ go@pull-3970-v0.9.0
✅ go@main-v0.9.0
✅ java@main-main
✅ java@main-pull-3970
✅ go@main-main
✅ java@main-v0.9.0
cukes-report
✅ js@main-main
✅ js@main-pull-3970
✅ js@main-v0.9.0
govulncheck-failure-8
opentdf~~platform~~Y17J1X.dockerbuild
govulncheck-failure-3
govulncheck-failure-1

github-actions · 2026-09-03T21:45:37Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	192.538866ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	102.294874ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	559.716521ms
Throughput	178.66 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	48.308717874s
Average Latency	481.975531ms
Throughput	103.50 requests/second

github-actions · 2026-09-03T21:55:01Z

X-Test Results

✅ go@main-pull-3970
✅ go@pull-3970-main
✅ go@main-v0.9.0
✅ go@pull-3970-v0.9.0
✅ go@main-main
cukes-report
✅ java@main-main
✅ go@pull-3970-pull-3970
bats-test-results
✅ js@main-main
✅ java@main-v0.9.0
✅ java@main-pull-3970
✅ js@main-pull-3970
✅ js@main-v0.9.0
govulncheck-failure-8
opentdf~~platform~~YCB2VX.dockerbuild
govulncheck-failure-3
govulncheck-failure-1

golangci-lint v2.13.2 enforces sloglint's key-naming-case: snake. Rename the one offending key on the fakeKeyIndex LogValue. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>

github-actions · 2026-09-04T13:19:41Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	227.405981ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	129.693067ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	441.024637ms
Throughput	226.74 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	59.533660526s
Average Latency	593.070818ms
Throughput	83.99 requests/second

github-actions · 2026-09-04T13:20:35Z

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

otdfctl
service
tests-bdd

See the workflow run for details.

github-actions · 2026-09-04T13:28:53Z

X-Test Results

✅ go@main-pull-3970
✅ go@pull-3970-pull-3970
bats-test-results
✅ go@main-v0.9.0
✅ go@main-main
✅ go@pull-3970-main
✅ java@main-pull-3970
✅ js@main-main
cukes-report
✅ js@main-pull-3970
✅ java@main-v0.9.0
✅ java@main-main
✅ js@main-v0.9.0
✅ go@pull-3970-v0.9.0
opentdf~~platform~~2ZOJ8I.dockerbuild
govulncheck-failure-8
govulncheck-failure-3
govulncheck-failure-1

dmihalcik-virtru requested review from a team as code owners September 3, 2026 19:50

github-actions Bot added comp:kas Key Access Server size/xs labels Sep 3, 2026

dmihalcik-virtru force-pushed the fix/lint-kas-sloglint branch from f8bfb47 to 9d6a78b Compare September 3, 2026 21:39

dmihalcik-virtru mentioned this pull request Sep 3, 2026

chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968

Merged

This was referenced Sep 3, 2026

fix(examples): DSPX-4607 clear goconst and SA1019 lint findings #3974

Open

fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975

Open

This was referenced Sep 4, 2026

fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977

Open

fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978

Open

fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake

50230b1

golangci-lint v2.13.2 enforces sloglint's key-naming-case: snake. Rename the one offending key on the fakeKeyIndex LogValue. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>

dmihalcik-virtru force-pushed the fix/lint-kas-sloglint branch from 9d6a78b to 50230b1 Compare September 4, 2026 13:13

Uh oh!

Conversation

dmihalcik-virtru commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Testing

DSPX-4607 burndown index

Uh oh!

coderabbitai Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actions Bot commented Sep 3, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 3, 2026

X-Test Results

Uh oh!

github-actions Bot commented Sep 3, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 3, 2026

X-Test Results

Uh oh!

github-actions Bot commented Sep 4, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 4, 2026

⚠️ Govulncheck found vulnerabilities ⚠️

Uh oh!

github-actions Bot commented Sep 4, 2026

X-Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dmihalcik-virtru commented Sep 3, 2026 •

edited

Loading

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading