Generic cells in doppel#663
Open
mkeeter wants to merge 2 commits into
Open
Conversation
mkeeter
force-pushed
the
mkeeter/generic-cells
branch
from
8b9e7dd to
89d1b37
Compare
mkeeter
force-pushed
the
mkeeter/struct-field-unpacking
branch
from
c7878a4 to
4bad0ff
Compare
mkeeter
force-pushed
the
mkeeter/generic-cells
branch
from
89d1b37 to
b3a0238
Compare
mkeeter
force-pushed
the
mkeeter/struct-field-unpacking
branch
from
4bad0ff to
1469947
Compare
mkeeter
force-pushed
the
mkeeter/generic-cells
branch
from
b3a0238 to
8b10ba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(staged on #662)
This PR makes cell types in
doppelgeneric, then uses that new functionality where relevant.It requires editing the proc macro to support generic parameters, but then can remove the explicit
impl Load for MaybeUninit<T>implementation.