feat: custom ico for favico + static file for i.e. unraid#13
Merged
Conversation
tmakuch
commented
Jan 27, 2026
| onClick={() => navigate('/')} | ||
| > | ||
| <Terminal sx={{ mr: 2 }} /> | ||
| <img src={logo} alt="logo" width="24px" style={{marginRight: '5px'}}/> |
Contributor
Author
There was a problem hiding this comment.
Playing devils advocate: using .ico directly in the webpage is not strictly recommended as some browsers might not display it. Not sure if internet explorer/netscape is in the scope tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You lack a logo, let me suggest one ;)
Added favicon and updated the header. Additionally readme uses a png that could be used in i.e. unraid.
PR contains source file for the logo, tho .ico itself was additionally edited to be more clear on 16x16 resolution (ico itself contains 16x16, 32x32, 64x64 and 128x128 in cause some day it will become a desktop app).
Preview on firefox/edge/chrome:
