Skip to content

feat: custom ico for favico + static file for i.e. unraid #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pozgo merged 1 commit into from
Jan 27, 2026
Merged

feat: custom ico for favico + static file for i.e. unraid #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Web CLI
# <img src="docs/images/webcli.png" width="24px"/> Web CLI

[![Go Version](https://img.shields.io/badge/Go-1.21+-00ADD8?style=flat&logo=go)](https://golang.org)
[![React](https://img.shields.io/badge/React-18-61DAFB?style=flat&logo=react)](https://react.dev)
Expand Down
Binary file added docs/images/webcli.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/sources/webcli.xcf
View file
Open in desktop
Binary file not shown.
Binary file added frontend/assets/favicon.ico
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link rel="icon" type="image/svg+xml" href="/assets/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Web CLI</title>
</head>
Expand Down
7 changes: 4 additions & 3 deletions frontend/src/components/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import React, { useState, useEffect, useCallback } from 'react';
import React from 'react';
import { AppBar, Toolbar, Typography, Box, IconButton, Tooltip } from '@mui/material';
import { Terminal, Api } from '@mui/icons-material';
import { Api } from '@mui/icons-material';
import GitHubIcon from '@mui/icons-material/GitHub';
import { useNavigate } from 'react-router-dom';
import ThemeToggle from './ThemeToggle';
import VaultIcon from './shared/VaultIcon';
import logo from "../../assets/favicon.ico"

/**
* Header component - displays the application header with logo and theme toggle
Expand All @@ -29,7 +30,7 @@ const Header = ({ mode, toggleTheme }) => {
}}
onClick={() => navigate('/')}
>
<Terminal sx={{ mr: 2 }} />
<img src={logo} alt="logo" width="24px" style={{marginRight: '5px'}}/>

@tmakuch tmakuch Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing devils advocate: using .ico directly in the webpage is not strictly recommended as some browsers might not display it. Not sure if internet explorer/netscape is in the scope tho.

<Typography variant="h6" component="div">
Web CLI
</Typography>
Expand Down
Loading