fix(flows): exit 2 when flows run selects no runnable flow - #1519
Conversation
Plumbing only; no behavior change yet. The flag and the two new messages are wired in the following commits.
A selection of only iOS, Basic, or Electron flows reported success with nothing executed, as did a selection of flows that declare no target. Refs WIZ-11675
Refs WIZ-11675
The exit code and the --allow-no-match downgrade were triplicated across the two command handlers and the runner, so changing the policy meant three edits.
The local path told the user to run 'qawolf flows run --allow-no-match', which drops the pattern they typed and runs every flow. The --env path never mentioned the flag at all. Also records the new cause of exit 2 in the exit-code contract.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 45 seconds Limit details: You’ve used all 3 included reviews currently available. Your 49 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
Comment |
Relates to WIZ-11675
Overview of Changes
flows runexited 0 when its pattern selected nothing, so a typo'd pattern reported success with nothing run. It now exits 2, as the--envpath already did. Two cases beyond the ticket's repro close the same hole: files that declare notarget, and a selection of only iOS, Basic, or Electron flows.--allow-no-matchrestores exit 0.Testing
Reverting either guard turns 5 and 2 tests red. Ran the built binary against fixture flows for each case.
bun run typecheck bun run lint bun run format:check bun run knip bun run test bun run buildChecklist
CI that currently passes on an empty selection starts failing. That is the bug. Only the no-
targetcase was outside the repro; keep it at exit 2?