Revert: SFSEC-331 Fix PHP version #6ff9471 - #139
Merged
Merged
Conversation
shoppingfeed-titusm
requested review from
d3vpasha
and
a lite review from Copilot
September 14, 2026 09:43
2 tasks
There was a problem hiding this comment.
🔵 Needs a closer look
The CI matrix omits PHP 8.4 and 8.5 despite the Composer constraint advertising support for them.
Pull request overview
Reverts PHP version changes to restore PHP 8.0 compatibility.
Changes:
- Sets the Composer requirement to PHP
>=8.0. - Updates CI coverage to PHP 8.0–8.3.
File summaries
| File | Summary |
|---|---|
composer.json |
Restores the PHP >=8.0 requirement. |
.github/workflows/php.yml |
Updates the PHP test matrix; PHP 8.4 and 8.5 remain unvalidated. |
Review details
Suppressed comments (1)
.github/workflows/php.yml:15
- This matrix drops PHP 8.4 and 8.5 even though
composer.jsonstill advertises support for every PHP version>=8.0. That leaves the currently released versions unvalidated, so compatibility regressions there can merge unnoticed; keep the newer versions in the matrix while adding the older versions, or narrow the Composer constraint if they are intentionally unsupported.
phpv: [ "8.0", "8.1", "8.2", "8.3" ]
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
@Aurelieluciani could you please approve and then merge if it's okai with you ? |
Aurelieluciani
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the issue
https://shopping-feed.atlassian.net/browse/SFSEC-331
Reason for this PR
Aikido scan > Revert unwanted changes
What does the PR do
How to test