Check data quality per observation at the site - #1676
Conversation
Contains a python script for implementing data quality check and associated config file. Note: Path to the mapmaker on pwg-scripts, given inside the config file under mapmaker_path needs to be modified.
mmccrackan
left a comment
mmccrackan
left a comment
There was a problem hiding this comment.
Overall looks solid, just some starting comments mostly on how it integrates into the site-pipeline work flow.
mmccrackan
left a comment
mmccrackan
left a comment
There was a problem hiding this comment.
Some additional comments, which are mainly just formatting suggestions and some questions. Might want to see if you can pass it through a python linter just to clear up some extra/missing spaces.
I think the only major things are about the output file format, adding an overwrite option, and the question about whether it re-runs already completed obs or not.
|
One other comment but can you move the Yaml config file to a draft PR over at https://github.com/simonsobs/site-pipeline-configs and remove it here? Fine to leave the paths as they are until we finalize them. |
|
One other comment but we should probably rename the file to something that is more planet map specific. Also if you could add a short entry to the docs, that would be awesome: https://github.com/simonsobs/sotodlib/blob/master/docs/site_pipeline.rst |
2 participants
Contains a python script for implementing data quality check and associated config file.
Note: Path to the mapmaker on pwg-scripts, given inside the config file under mapmaker_path needs to be modified.