Fix EquilibriumPlot crash on empty/sparse data - #218
Draft
meganrm wants to merge 1 commit into
Draft
Conversation
…a points (B3, B8) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
meganrm
requested review from
frasercl and
toloudis
and removed request for
a team
August 11, 2026 23:54
meganrm
marked this pull request as draft
August 12, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small
EquilibriumPlotcrashed / produced NaN garbage when fewer than 3 equilibrium points had been recorded.Math.max(...x)and thebestFitregression (regression.logarithmic/regression.exponential) ran unconditionally, before the component's ownbestFitVisible = x.length >= 3guard — which only gated display, not the computation itself.Fixes #225
Solution
Guarded the
bestFituseMemoand the standaloneMath.max(...x)with the samex.length >= 3threshold already used elsewhere in the component, short-circuiting to a safe default ({ x: [], y: [], value: NaN }) when there isn't enough data. No behavior change for 3+ points — the plot already correctly hid the best-fit line/indicator below 3 points, this just stops the underlying computation from crashing on the way there.Type of change
Please delete options that are not relevant.
Change summary:
bestFitregression against empty/too-few data pointsMath.max(...x)the same waytickvalsso it doesn't pushNaNwhen the best-fit line isn't visibleSteps to Verify:
Screenshots (optional):
Keyfiles (delete if not relevant):
Thanks for contributing!