Skip to content

Fix EquilibriumPlot crash on empty/sparse data #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
meganrm wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix EquilibriumPlot crash on empty/sparse data #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/components/plots/EquilibriumPlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,17 @@ const EquilibriumPlot: React.FC<PlotProps> = ({
adjustableAgentName,
} = useSimulariumSimulation();
const { module } = useSimulariumUi();
const xMax = Math.max(...x);
const xMax = x.length ? Math.max(...x) : 0;
const xAxisMax = Math.max(eqConstant * 2, xMax * 1.1);

// Calculate the best fit line for the data points
const bestFit = useMemo(() => {
// the best fit line is only shown once there are 3 or more points
// (see bestFitVisible below); with fewer points the regression
// library produces NaN/garbage, so skip the computation entirely
if (x.length < 3) {
return { x: [], y: [], value: NaN };
}
const regressionData: DataPoint[] = x.map((xVal, index) => [
xVal,
y[index],
Expand Down Expand Up @@ -230,7 +236,9 @@ const EquilibriumPlot: React.FC<PlotProps> = ({
color: getAgentColor(adjustableAgentName),
},
tickmode: bestFitVisible ? ("array" as const) : ("auto" as const),
tickvals: [...xAxisTicks, Number(bestFit.value.toFixed(1))],
tickvals: bestFitVisible
? [...xAxisTicks, Number(bestFit.value.toFixed(1))]
: xAxisTicks,
},
yaxis: {
...AXIS_SETTINGS,
Expand Down
Loading