Add a config option for storing lineinfo into the SDFG#2321
Merged
Conversation
romanc
changed the title
tbennun
approved these changes
Apr 17, 2026
Collaborator
|
cscs-ci run |
auto-merge was automatically disabled
April 18, 2026 06:12
Head branch was pushed to by a user without write access
romanc
force-pushed
the
romanc/debug-info-config
branch
from
7669230 to
045403e
Compare
Contributor
Author
|
rebased to fix a conflict in the imports of |
tbennun
approved these changes
Apr 18, 2026
Collaborator
|
cscs-ci run |
This was referenced Apr 21, 2026
romanc
added a commit
to romanc/dace
that referenced
this pull request
Apr 24, 2026
## Description In PR spcl#2321 we introduced a way to turn of automatic stack inspection when adding a node to a state without explicitly stating debug info (such as file name, line info, ...). Since merging this PR, we get a ton of `DeprecationWarning`s from code added in `_get_debug_info()`. In a first attempt (see PR spcl#2344), we tried to work around the issue by setting `._default_line_info` on the state. This method proved to be very verbose and unnecessarily complicates parsing, where we have a legitimate use-case for explicitly passing along an explicit `DebugInfo`. This PR suggests to keep the API of `state.add_*()` functions as before, partially reverting changes from PR spcl#2321. Doing so, we can drop the deprecation warnings because nothing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we build an SDFG, there's the option to store
DebugInfowith some SDFG nodes. For example, thisDebugInfocan be used to store file & line information of parsed code when building an SDFG. When using the SDFG API, the default is to inspect the python stack and extract file & line information from there. These calls toinspectcan/will be expensive, especially for bigger graphs.This PR proposes to add a configuration option,
compiler.lineinfo, to drive this behavior from a single place. The defaults are kept as is, i.e. we keep inspecting the stack by default. However, the config option allows a central pace to turnDebugInfooff, which could be configured in production scenarios.