fix(splitter): keep CTE queries attached to inserts - #792
Open
edjubert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
A valid
INSERT INTO … WITH … SELECTstatement is split after the target columnlist because the statement splitter treats
WITHas the start of a newstatement.
PostgreSQL then receives the incomplete
INSERT INTO … (...)fragment andreports
syntax error at end of input.What is the new behavior?
WITHis now handled likeSELECTwhile splitting anINSERT, so aCTE-backed insert remains a single statement until its terminating semicolon.
A regression test also verifies that a subsequent semicolon-terminated
statement is still split separately.
Additional context
Validated with: