Skip to content

fix(splitter): keep CTE queries attached to inserts #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edjubert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(splitter): keep CTE queries attached to inserts #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions crates/pgls_statement_splitter/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,23 @@ END;",
.expect_statements(vec!["insert into tbl (id) select 1", "select 3"]);
}

#[test]
fn insert_with_cte() {
let insert = "INSERT INTO target (id)
WITH source AS (
SELECT 1 AS id
)
SELECT id FROM source;";
let input = format!(
"{insert}
SELECT 2;"
);

Tester::from(input.as_str())
.expect_statements(vec![insert, "SELECT 2;"])
.assert_no_errors();
}

#[test]
fn c_style_comments() {
Tester::from("/* this is a test */\nselect 1").expect_statements(vec!["select 1"]);
Expand Down
2 changes: 1 addition & 1 deletion crates/pgls_statement_splitter/src/splitter/dml.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ pub(crate) fn insert(p: &mut Splitter) -> SplitterResult {
p.expect(SyntaxKind::INSERT_KW)?;
p.expect(SyntaxKind::INTO_KW)?;

unknown(p, &[SyntaxKind::SELECT_KW])
unknown(p, &[SyntaxKind::WITH_KW, SyntaxKind::SELECT_KW])
}

pub(crate) fn update(p: &mut Splitter) -> SplitterResult {
Expand Down