fix(release): use workspace-relative dist paths for cross-platform staging - #34
Merged
Merged
Conversation
Switching --out-dir from an absolute runner.temp path to a workspace-relative dist/ path introduced a regression on ALL five platforms, not just Windows: tar is spawned with cwd=binDir, so a relative archive path resolved against the target dir instead of the invocation dir. Reproduced locally with a fake bin dir and a relative --out-dir: tar (child): dist/release-tarball-linux-x64/...tar.gz: Cannot open: No such file or directory tar failed with exit code 2 resolve() the out-dir before joining. Re-probed: the archive now lands at the expected workspace-relative path and contains exactly the `comment-checker` member, which is what the publish-side cross-check extracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows runner artifact upload failure () by using workspace-relative directories across all runners.