Skip to content

fix(release): use workspace-relative dist paths for cross-platform staging #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanleecode merged 2 commits into from
Aug 23, 2026
Merged

fix(release): use workspace-relative dist paths for cross-platform staging #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2a273d
fix(release): use workspace-relative dist paths for cross-platform ar…
systemfsoftware-maker Aug 23, 2026
3ab5315
fix(release): resolve tarball path to absolute before tar's cwd override
systemfsoftware-maker Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-windows-staging-path.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@systemfsoftware/claude-code-comment-checker': patch
---

Fix Windows artifact upload path and execute full release pipeline.
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,24 +106,24 @@ jobs:
run: ./scripts/tools/run-binary-smoke.ts --target ${{ matrix.target }} --bin-dir target/${{ matrix.target }}/release

- name: Stage platform package
run: ./scripts/tools/stage-platform-package.ts --target ${{ matrix.target }} --suffix ${{ matrix.suffix }} --stage ${{ runner.temp }}/platform-${{ matrix.suffix }} --bin-dir target/${{ matrix.target }}/release
run: ./scripts/tools/stage-platform-package.ts --target ${{ matrix.target }} --suffix ${{ matrix.suffix }} --stage dist/staging/platform-${{ matrix.suffix }} --bin-dir target/${{ matrix.target }}/release

- name: Bundle tarball
run: ./scripts/tools/bundle-release-tarball.ts --target ${{ matrix.target }} --bin-dir target/${{ matrix.target }}/release --out-dir ${{ runner.temp }}/release-tarball-${{ matrix.suffix }}
run: ./scripts/tools/bundle-release-tarball.ts --target ${{ matrix.target }} --bin-dir target/${{ matrix.target }}/release --out-dir dist/release-tarball-${{ matrix.suffix }}

- name: Upload artifacts
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: release-${{ matrix.suffix }}
path: |
${{ runner.temp }}/release-tarball-${{ matrix.suffix }}/comment-checker-${{ matrix.target }}.tar.gz
${{ runner.temp }}/platform-${{ matrix.suffix }}/binarySha256
dist/release-tarball-${{ matrix.suffix }}/comment-checker-${{ matrix.target }}.tar.gz
dist/staging/platform-${{ matrix.suffix }}/binarySha256

- name: Upload staged platform package
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: platform-stage-${{ matrix.suffix }}
path: ${{ runner.temp }}/platform-${{ matrix.suffix }}
path: dist/staging/platform-${{ matrix.suffix }}
if-no-files-found: error

publish:
Expand Down
6 changes: 4 additions & 2 deletions scripts/tools/bundle-release-tarball.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env -S deno run --allow-run=tar --allow-read --allow-write --allow-env

import { parseArgs } from '@std/cli/parse-args'
import { join } from '@std/path'
import { join, resolve } from '@std/path'
import { type Target, TARGETS_PATH } from '../lib/shared.ts'

const flags = parseArgs(Deno.args, {
Expand All @@ -27,7 +27,9 @@ if (!row) {
}

await Deno.mkdir(outDir, { recursive: true })
const tarPath = join(outDir, `comment-checker-${targetName}.tar.gz`)
// tar runs with cwd=binDir, so the archive path must be absolute: a relative
// one would resolve against binDir instead of the invocation directory.
const tarPath = join(resolve(outDir), `comment-checker-${targetName}.tar.gz`)

const tarCmd = new Deno.Command('tar', {
args: ['-czf', tarPath, row.bin],
Expand Down
Loading