bug: ensure drained versions stable sort in status#458
Merged
Conversation
The reconciler loop is "hot", meaning, it is bumping the Revision of the WorkerDeployment CRs too often. One of the reasons for this is that the WorkerDeployment.Status struct was being evaluated as different from a previous iteration of the reconciler loop for the same WorkerDeployment due to differences in the sort order of the collection of drained build IDs. This commit adds stable sorting of these drained build IDs in the `WorkerDeploymentStatus` struct in order to eliminate this false positive detection of a difference in status. The other cause for false-positive detection of status differences identified in issue temporalio#415 -- where rate limiting errors cause a temporary condition change -- will be addressed in a followup PR. Issue temporalio#415 Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
Shivs11
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reconciler loop is "hot", meaning, it is bumping the Revision of the WorkerDeployment CRs too often. One of the reasons for this is that the WorkerDeployment.Status struct was being evaluated as different from a previous iteration of the reconciler loop for the same WorkerDeployment due to differences in the sort order of the collection of drained build IDs.
This commit adds stable sorting of these drained build IDs in the
WorkerDeploymentStatusstruct in order to eliminate this false positive detection of a difference in status.The other cause for false-positive detection of status differences identified in issue #415 -- where rate limiting errors cause a temporary condition change -- will be addressed in a followup PR.
Issue #415