Skip to content

bug: ensure drained versions stable sort in status #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaypipes merged 1 commit into from
Jul 24, 2026
+14 −0
Merged

bug: ensure drained versions stable sort in status #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions internal/controller/state_mapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
package controller

import (
"cmp"
"slices"

"github.com/temporalio/temporal-worker-controller/api/v1alpha1"
"github.com/temporalio/temporal-worker-controller/internal/k8s"
"github.com/temporalio/temporal-worker-controller/internal/temporal"
Expand Down Expand Up @@ -65,6 +68,17 @@ func (m *stateMapper) mapToStatus(targetBuildID string) *v1alpha1.WorkerDeployme
deprecatedVersions = append(deprecatedVersions, versionStatus)
}
}
// NOTE(jaypipes): Need to sort the deprecated versions here in order to
// prevent sort order differences from causing unnecessary status
// generation increments.
//
// See: https://github.com/temporalio/temporal-worker-controller/issues/415
slices.SortStableFunc(
deprecatedVersions,
func(a, b *v1alpha1.DeprecatedWorkerDeploymentVersion) int {
return cmp.Compare(a.BuildID, b.BuildID)
},
)
status.DeprecatedVersions = deprecatedVersions

// Set version count from temporal state (directly from VersionSummaries via Versions map)
Expand Down
Loading