Skip to content

*: update titan & rocksdb with #434 - #857

Merged
ti-chi-bot[bot] merged 1 commit into
tikv:masterfrom
LykxSassinator:update_rocksdb_for_12484
Aug 7, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
tikv:masterfrom
LykxSassinator:update_rocksdb_for_12484

Conversation

@LykxSassinator

@LykxSassinator LykxSassinator commented Aug 6, 2026

Copy link
Copy Markdown

Description

Upgrade tikv-rocksdb tikv/rocksdb#434 to backport facebook/rocksdb#12484 fix.

Summary by CodeRabbit

  • Chores
    • Updated underlying database components to newer revisions.
    • Improved the foundation used for storage and data handling.
    • No direct changes to the application’s user-facing functionality.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot Bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Aug 6, 2026
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates the rocksdb and titan submodule references to new commits. No exported or public declarations change.

Changes

Submodule updates

Layer / File(s) Summary
Update RocksDB and Titan pointers
librocksdb_sys/rocksdb, librocksdb_sys/libtitan_sys/titan
The submodule pointers now reference new commits.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm, approved

Suggested reviewers: connor1996, v01dstar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the update to the titan and rocksdb submodules for pull request #434.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@librocksdb_sys/rocksdb`:
- Line 1: Update the librocksdb_sys/rocksdb submodule pointer from
3ddc406f37c00c4002b202c4c52289f8723d1c24 to the current resolved commit
c0999108170b916d583d276957ad73ec3f98f407, ensuring it contains the overflow-safe
output_level_inputs_size + expanded_inputs_size checks.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ee3a9bc-68ee-4cda-b2f3-a116a85b82d9

📥 Commits

Reviewing files that changed from the base of the PR and between cdb577c and c099910.

📒 Files selected for processing (2)
  • librocksdb_sys/libtitan_sys/titan
  • librocksdb_sys/rocksdb

Comment thread librocksdb_sys/rocksdb
@@ -1 +1 @@
Subproject commit 044e8b96e6a8422985e837a721a202bf669604b3
Subproject commit 3ddc406f37c00c4002b202c4c52289f8723d1c24

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

submodule="librocksdb_sys/rocksdb"
expected="3ddc406f37c00c4002b202c4c52289f8723d1c24"
source_file="db/compaction/compaction_picker.cc"

test "$(git -C "$submodule" rev-parse HEAD)" = "$expected"

matches="$(
  git -C "$submodule" grep -n -E \
    'output_level_inputs_size[[:space:]]*\+[[:space:]]*expanded_inputs_size' \
    "$expected" -- "$source_file" || true
)"

if [[ -n "$matches" ]]; then
  echo "Overflow-prone compaction limit checks remain:"
  echo "$matches"
  exit 1
fi

echo "No direct overflowing addition found in the selected compaction checks."

Repository: tikv/rust-rocksdb

Length of output: 155


Fix the RocksDB submodule pointer before relying on the overflow-safe compaction limit check.

librocksdb_sys/rocksdb is pinned to 3ddc406f37c00c4002b202c4c52289f8723d1c24, but the current submodule commit is c0999108170b916d583d276957ad73ec3f98f407. Re-point the submodule to a known resolved commit that contains the fixed output_level_inputs_size + expanded_inputs_size checks before relying on that behavior.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@librocksdb_sys/rocksdb` at line 1, Update the librocksdb_sys/rocksdb
submodule pointer from 3ddc406f37c00c4002b202c4c52289f8723d1c24 to the current
resolved commit c0999108170b916d583d276957ad73ec3f98f407, ensuring it contains
the overflow-safe output_level_inputs_size + expanded_inputs_size checks.

Source: MCP tools

@LykxSassinator LykxSassinator changed the title *: update rocksdb #434 *: update titan & rocksdb with #434 Aug 6, 2026
@ti-chi-bot ti-chi-bot Bot added the lgtm label Aug 6, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-06 07:21:31.698152542 +0000 UTC m=+2685477.734247608: ☑️ agreed by overvenus.

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 6, 2026

@Connor1996 Connor1996 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot

ti-chi-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Connor1996,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
ti-chi-bot Bot merged commit 63eeecd into tikv:master Aug 7, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants