*: update titan & rocksdb with #434 - #857
Conversation
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
📝 WalkthroughWalkthroughThe pull request updates the ChangesSubmodule updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@librocksdb_sys/rocksdb`:
- Line 1: Update the librocksdb_sys/rocksdb submodule pointer from
3ddc406f37c00c4002b202c4c52289f8723d1c24 to the current resolved commit
c0999108170b916d583d276957ad73ec3f98f407, ensuring it contains the overflow-safe
output_level_inputs_size + expanded_inputs_size checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9ee3a9bc-68ee-4cda-b2f3-a116a85b82d9
📒 Files selected for processing (2)
librocksdb_sys/libtitan_sys/titanlibrocksdb_sys/rocksdb
| @@ -1 +1 @@ | |||
| Subproject commit 044e8b96e6a8422985e837a721a202bf669604b3 | |||
| Subproject commit 3ddc406f37c00c4002b202c4c52289f8723d1c24 | |||
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
submodule="librocksdb_sys/rocksdb"
expected="3ddc406f37c00c4002b202c4c52289f8723d1c24"
source_file="db/compaction/compaction_picker.cc"
test "$(git -C "$submodule" rev-parse HEAD)" = "$expected"
matches="$(
git -C "$submodule" grep -n -E \
'output_level_inputs_size[[:space:]]*\+[[:space:]]*expanded_inputs_size' \
"$expected" -- "$source_file" || true
)"
if [[ -n "$matches" ]]; then
echo "Overflow-prone compaction limit checks remain:"
echo "$matches"
exit 1
fi
echo "No direct overflowing addition found in the selected compaction checks."Repository: tikv/rust-rocksdb
Length of output: 155
Fix the RocksDB submodule pointer before relying on the overflow-safe compaction limit check.
librocksdb_sys/rocksdb is pinned to 3ddc406f37c00c4002b202c4c52289f8723d1c24, but the current submodule commit is c0999108170b916d583d276957ad73ec3f98f407. Re-point the submodule to a known resolved commit that contains the fixed output_level_inputs_size + expanded_inputs_size checks before relying on that behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@librocksdb_sys/rocksdb` at line 1, Update the librocksdb_sys/rocksdb
submodule pointer from 3ddc406f37c00c4002b202c4c52289f8723d1c24 to the current
resolved commit c0999108170b916d583d276957ad73ec3f98f407, ensuring it contains
the overflow-safe output_level_inputs_size + expanded_inputs_size checks.
Source: MCP tools
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Upgrade tikv-rocksdb tikv/rocksdb#434 to backport facebook/rocksdb#12484 fix.
Summary by CodeRabbit