ci: verify the install script against each published release - #23
Merged
Conversation
The install-script workflow had a `release: published` trigger intended to catch drift in the release layout -- renamed assets, a missing checksums.txt -- right when it happens. It never fired: GoReleaser publishes the release using GITHUB_TOKEN, and events created by that token do not start new workflow runs. Confirmed against v0.36.0, which produced zero release-triggered runs. Move that verification into release.yml as a job hanging off `needs: goreleaser`, which makes the ordering explicit and the run guaranteed. It installs the exact tag just published (rather than "latest") on both Linux and macOS and asserts the reported version matches. The weekly schedule and path-based PR triggers stay where they are. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22.
That PR added a
release: publishedtrigger to the install-script workflow so release-layout drift would be caught the moment it happens. It never fires. GoReleaser publishes usingGITHUB_TOKEN, and events created by that token do not trigger new workflow runs. Confirmed empirically against v0.36.0 — zero release-triggered runs.Worse than missing coverage: it looked like coverage.
Fix
Move the check into
release.ymlas averify-installjob withneeds: goreleaser, so ordering is explicit and the run is guaranteed. It installs the exact tag just published (notlatest) on bothubuntu-latestandmacos-latest, and asserts the reported version matches the tag.The weekly schedule and path-based PR triggers in
install-test.ymlare unchanged.🤖 Generated with Claude Code