Yieldmo Bid Adapter: remove dead Topics handling (Chrome/Prebid killed Topics) - #68
Open
ym-aaron wants to merge 1 commit into
Open
Yieldmo Bid Adapter: remove dead Topics handling (Chrome/Prebid killed Topics)#68ym-aaron wants to merge 1 commit into
ym-aaron wants to merge 1 commit into
Conversation
Chrome removed the Privacy-Sandbox Topics API and Prebid made topicsFpdModule a no-op as of 11.26 (prebid#15369) — processFpd now writes nothing to ortb2.user.data. The adapter's getTopics reads ortb2.user.data for segtax 600-609, so it now reads a signal that no longer exists. Remove getTopics(), its call site, and the banner/video `topics` send-sites (plus the two topics unit tests). This also drops a latent bug in that path: getTopics built the array with Object.values(segment).map(Number), but ortb2 segments are [{ id }] objects, so it emitted topics:[null,null,null] whenever topics were present (Prebid < 11.26). Surfaced during the TDTN-8800 Prebid 9.53->11.x release audit. Refs TDTN-8800. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ym-aaron
force-pushed
the
bugfix/yieldmo-topics-segment-id
branch
from
July 28, 2026 22:11
3a61c96 to
b7d27ab
Compare
ym-aaron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Chrome removed the Privacy-Sandbox Topics API, and Prebid made
topicsFpdModulea no-op as of 11.26 (#15369) —processFpdnow returns first-party data untouched and writes nothing toortb2.user.data. The Yieldmo adapter'sgetTopicsreadsortb2.user.dataforsegtax600–609, so it now reads a signal that no longer exists.This removes the dead topics handling:
getTopics()and its call siteserverRequest.topics = JSON.stringify(...)) and video (serverRequest.topics = ...) send-sitesIt also eliminates a latent bug in that path:
getTopicsbuilt the array withObject.values(topicsData.segment).map(i => Number(i)), but ORTBuser.data[].segmentis an array of{ id }objects, soNumber({id})wasNaN→ the request senttopics:[null,null,null]whenever topics were present on Prebid < 11.26.Surfaced during the TDTN-8800 Prebid 9.53 → 11.x release audit.
Testing
gulp test --file test/spec/modules/yieldmoBidAdapter_spec.js: 67 passing.eslintclean.Refs TDTN-8800.
🤖 Generated with Claude Code