Skip to content

Yieldmo Bid Adapter: remove dead Topics handling (Chrome/Prebid killed Topics) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ym-aaron wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Yieldmo Bid Adapter: remove dead Topics handling (Chrome/Prebid killed Topics) #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions modules/yieldmoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export const spec = {
const videoBidRequests = bidRequests.filter(request => hasVideoMediaType(request));
const serverRequests = [];
const eids = getEids(bidRequests[0]) || [];
const topicsData = getTopics(bidderRequest);
const cdep = getCdep(bidderRequest);
if (bannerBidRequests.length > 0) {
const serverRequest = {
Expand All @@ -99,9 +98,6 @@ export const spec = {
deepAccess(bidderRequest, 'gppConsent.applicableSections') || []}),
us_privacy: deepAccess(bidderRequest, 'uspConsent') || '',
};
if (topicsData) {
serverRequest.topics = JSON.stringify(topicsData);
}
const gpc = getGPCSignal(bidderRequest);
if (gpc) {
serverRequest.gpc = gpc;
Expand Down Expand Up @@ -173,9 +169,6 @@ export const spec = {

if (videoBidRequests.length > 0) {
const serverRequest = openRtbRequest(videoBidRequests, bidderRequest);
if (topicsData) {
serverRequest.topics = topicsData;
}
if (eids.length) {
deepSetValue(serverRequest, 'user.ext.eids', eids);
};
Expand Down Expand Up @@ -444,25 +437,6 @@ function getCdep(bidderRequest) {
return cdep;
}

function getTopics(bidderRequest) {
const userData = deepAccess(bidderRequest, 'ortb2.user.data') || [];
const topicsData = userData.filter((dataObj) => {
const segtax = dataObj.ext?.segtax;
return segtax >= 600 && segtax <= 609;
})[0];

if (topicsData) {
const topicsObject = {
taxonomy: topicsData.ext.segtax,
classifier: topicsData.ext.segclass,
// topics needs to be array of numbers
topics: Object.values(topicsData.segment).map(i => Number(i)),
};
return topicsObject;
}
return null;
}

/**
* @param {BidRequest} bidRequest bidder request object.
* @return Object OpenRTB's 'imp' (impression) object
Expand Down
47 changes: 0 additions & 47 deletions test/spec/modules/yieldmoBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,26 +407,6 @@ describe('YieldmoAdapter', function () {
expect(placementInfo).to.include('"gpid":"/6355419/Travel/Europe/France/Paris"');
});

it('should add topics to the banner bid request', function () {
const biddata = build([mockBannerBid()], mockBidderRequest({ortb2: { user: {
data: [
{
ext: {
segtax: 600,
segclass: '2206021246',
},
segment: ['7', '8', '9'],
},
],
}}}));

expect(biddata[0].data.topics).to.equal(JSON.stringify({
taxonomy: 600,
classifier: '2206021246',
topics: [7, 8, 9],
}));
});

it('should add cdep to the banner bid request', function () {
const biddata = build(
[mockBannerBid()],
Expand Down Expand Up @@ -714,33 +694,6 @@ describe('YieldmoAdapter', function () {
expect(buildAndGetData([mockVideoBid({...params})]).user.ext.eids).to.eql(params.fakeUserIdAsEids);
});

it('should add topics to the bid request', function () {
const videoBidder = mockBidderRequest(
{
ortb2: {
user: {
data: [
{
ext: {
segtax: 600,
segclass: '2206021246',
},
segment: ['7', '8', '9'],
},
],
},
},
},
[mockVideoBid()]
);
const payload = buildAndGetData([mockVideoBid()], 0, videoBidder);
expect(payload.topics).to.deep.equal({
taxonomy: 600,
classifier: '2206021246',
topics: [7, 8, 9],
});
});

it('should send gpc in the bid request', function () {
const videoBidder = mockBidderRequest(
{
Expand Down
Loading