fix(video): isolate concurrent remux temp files - #531
Open
harshitethic wants to merge 1 commit into
Open
Conversation
This was referenced Sep 14, 2026
kstonekuan
requested changes
Sep 14, 2026
kstonekuan
left a comment
Contributor
There was a problem hiding this comment.
ruff check fails on tests/test_video_concurrency.py (missing annotations on tmp_path, monkeypatch, fake_run), so this would turn main red.
The fix is right. The test is weaker than #530 asks for: with subprocess.run mocked it pins that two calls get distinct temp names, which catches a revert to the fixed name but cannot catch what the issue measured. #530 wants the cached final to match a single-process reference by sha256 and the full frame count to extract.
The barrier and the not path.exists() check are the right instincts. Worth saying whether the sha256 version is practical here or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<output>.tmpremux path with a unique sibling temporary file per callreplace()behavior and failure cleanupVerification
git diff --checkFixes #530