Skip to content

Powerloop HV Charge Timeout & Safe Discharge#3829

Open
Andrewyx wants to merge 11 commits into
UBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/pwr_done_pin
Open

Powerloop HV Charge Timeout & Safe Discharge#3829
Andrewyx wants to merge 11 commits into
UBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/pwr_done_pin

Conversation

@Andrewyx

@Andrewyx Andrewyx commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Firmware for enabling HV and safe discharge after 2 seconds of continuous charging (without completion).

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Andrewyx Andrewyx changed the title Andrewyx/pwr done pin Powerloop HV Charge Timeout & Safe Discharge Jul 2, 2026
@williamckha williamckha mentioned this pull request Jul 4, 2026
4 tasks
@nycrat

nycrat commented Jul 5, 2026

Copy link
Copy Markdown
Member

@Andrewyx you'll have to pull from master or else ci fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants