Fix default gamecontroller interface for macos#3840
Merged
williamckha merged 6 commits intoJul 4, 2026
Merged
Conversation
This reverts commit 4d0dcc7.
nycrat
approved these changes
Jul 4, 2026
sauravbanna
approved these changes
Jul 4, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original PR merged into
robocup_2026: #3819Discovered this cause we don't have good wifi here at robocup, found out by turning off wifi macos can't use the en0 interface which is referenced in gamecontroller binary context manager. This PR uses netifaces to get primary interface instead of relying on en0 for macos, this does not need to be changed on linux since the multicast messages get sent to the loopback interface.
Testing Done
Without the changes, running
./tbots.py run thunderscope --enable_autorefwith wifi turned off results in this error:After the changes, everything works including gamecontroller.
NOTE: there is an additional bug fix for a bug introduced in #3766 about gamecontroller ports
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue