Singletons are now cached#1636
Merged
Merged
Conversation
Bromeon
added
c: engine
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1636 |
Bromeon
force-pushed
the
perf/singleton-cached-ptrs
branch
from
830a077 to
e0e5345
Compare
Member
Author
|
This revealed a latent bug, which I fixed first: #1638 |
Bromeon
force-pushed
the
perf/singleton-cached-ptrs
branch
from
e0e5345 to
617836c
Compare
Promote loads to `Acquire` and stores to `Release` (swap to `AcqRel`), so a store can act as a release gate publishing prior writes. Strictly stronger than the previous `Relaxed`, hence safe for existing use sites; free on x86 and negligible elsewhere. Enables the singleton pointer cache.
`SomeClass::singleton()` no longer re-fetches the singleton and rebuilds a `StringName` on every call. Now caches the pointer per singleton type, guarded by init/deinit levels to rule out dangling pointers.
Bromeon
force-pushed
the
perf/singleton-cached-ptrs
branch
from
617836c to
2a3387c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1577.
This PR caches Engine singletons. For User singletons, caching is planned in the future.