Always use godot_error in panic hook#1647
Open
QuinnPainter wants to merge 1 commit into
Open
Conversation
Bromeon
reviewed
Jun 26, 2026
| where | ||
| F: Fn() -> bool + Send + Sync + 'static, | ||
| { | ||
| pub fn set_gdext_hook() { |
Member
There was a problem hiding this comment.
Maybe rename this to install_godot_rust_hook now 🙂
Bromeon
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1647 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1632 prints are safe to do from any thread. So it's no longer necessary for the print inside the panic hook to be gated on experimental-threads.
(sidenote: is there a reason the backtrace isn't also printed in Godot?)