[SYCL] Update E2E to use access_mode [1/3] - #22842
Merged
Merged
Conversation
access::mode is deprecated in favor of access_mode. PR to add deprecations intel#22803
KornevNikita
changed the title
This was referenced Jul 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SYCL end-to-end tests to use sycl::access_mode (and access_mode::* enumerators) instead of the deprecated sycl::access::mode / access::mode spelling, aligning the test suite with SYCL 2020 naming.
Changes:
- Replace
buffer::get_access<access::mode::...>andaccessor<..., access::mode::...>with...<access_mode::...>/sycl::access_mode::...across E2E tests. - Update
constexprvariables and type aliases that referencedaccess::modeto useaccess_mode. - Minor formatting adjustments where long template parameter lists were touched.
Reviewed changes
Copilot reviewed 106 out of 106 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test-e2e/XPTI/buffer/use_host_ptr.cpp | Switches buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/multiple_queues.cpp | Switches buffer accessor mode to sycl::access_mode in multi-queue XPTI test. |
| sycl/test-e2e/XPTI/buffer/host_array.cpp | Switches buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/WorkGroupStatic/work_group_static_memory_class_scope.cpp | Updates get_access mode to access_mode. |
| sycl/test-e2e/WorkGroupScratchMemory/dynamic_alloc_ptr_alias.cpp | Updates get_access mode to access_mode. |
| sycl/test-e2e/USM/memset.cpp | Updates buffer accessor mode to access_mode. |
| sycl/test-e2e/USM/free_during_kernel_execution.cpp | Updates buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Tracing/buffer_printers.cpp | Updates accessor modes used by tracing test to access_mode. |
| sycl/test-e2e/SubGroup/vote.cpp | Updates subgroup test buffer accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/info.cpp | Updates subgroup info test accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/broadcast.hpp | Updates subgroup broadcast test accessor modes to access_mode. |
| sycl/test-e2e/SpecConstants/2020/non_native/spec_const_alignment_test.cpp | Updates spec-constant test access modes to sycl::access_mode. |
| sycl/test-e2e/SpecConstants/2020/host_apis.cpp | Updates buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Scheduler/MultipleDevices.cpp | Updates scheduler test accessor modes to access_mode. |
| sycl/test-e2e/Scheduler/HostAccDestruction.cpp | Updates scheduler test accessor mode to sycl::access_mode. |
| sycl/test-e2e/Scheduler/CommandCleanupThreadSafety.cpp | Updates scheduler test accessor mode to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-none-linear-float.cpp | Updates image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clamp-nearest.cpp | Updates image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-repeat-linear-float.cpp | Updates image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-mirror-nearest.cpp | Updates image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-clampedge-linear-float.cpp | Updates image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/basic-rw.cpp | Updates image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Regression/set-arg-local-accessor.cpp | Updates buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/queue_submit.cpp | Updates discard-write accessor mode spelling to sycl::access_mode. |
| sycl/test-e2e/Regression/multithread_write_accessor.cpp | Updates buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/mad_sat.cpp | Updates buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/kernel_name_class.cpp | Updates buffer accessor modes to sycl::access_mode throughout kernel-name coverage. |
| sycl/test-e2e/Regression/implicit_offset_debug_info.cpp | Updates accessor mode to access_mode. |
| sycl/test-e2e/Regression/image_access.cpp | Updates accessor template mode parameter to sycl::access_mode. |
| sycl/test-e2e/Regression/fsycl-host-compiler-win.cpp | Updates accessor mode to access_mode. |
| sycl/test-e2e/Regression/complex_global_object.cpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/atomic_load.cpp | Updates atomic accessor mode spelling to access_mode. |
| sycl/test-e2e/Reduction/reduction_usm_dw.cpp | Updates accessor modes (read/discard_write) to access_mode. |
| sycl/test-e2e/Reduction/reduction_range_1d_rw.cpp | Updates constexpr access mode type/value to access_mode. |
| sycl/test-e2e/Reduction/reduction_nd_ext_type.hpp | Updates constexpr access mode type/value to access_mode. |
| sycl/test-e2e/Reduction/reduction_ctor.cpp | Updates accessor template mode parameters to access_mode. |
| sycl/test-e2e/KernelParams/union_kernel_param.cpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/KernelParams/array-kernel-param-run.cpp | Updates accessor modes and accessor type alias to access_mode. |
| sycl/test-e2e/KernelCompiler/opencl_capabilities.cpp | Updates buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/KernelAndProgram/cache_env_vars.hpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_switch.cpp | Updates output buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_multiple_instructions.cpp | Updates input/output buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_imm_arg.cpp | Updates input/output buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_float_imm_arg.cpp | Updates input/output buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_arbitrary_ops_order.cpp | Updates input/output buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_no_opts.cpp | Updates output buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_empty.cpp | Updates output buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/HostInteropTask/interop-task-cuda.cpp | Updates host-task CUDA interop accessors to sycl::access_mode. |
| sycl/test-e2e/HostInteropTask/host-task-dependency4.cpp | Updates host-task accessor mode to sycl::access_mode. |
| sycl/test-e2e/HierPar/Inputs/hier_par_wgscope_impl.hpp | Updates hierarchical parallelism accessor modes to access_mode. |
| sycl/test-e2e/GroupInterface/leader_of.cpp | Updates group interface test accessor mode to access_mode. |
| sycl/test-e2e/GroupAlgorithm/back_to_back_collectives.cpp | Updates group algorithm test accessor modes to access_mode. |
| sycl/test-e2e/FreeFunctionKernels/template_specialization.cpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/wait_multiple_events.cpp | Updates accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/kernel_timing.cpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/event_reassociation_dependency.cpp | Updates accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_work_item_sizes.cpp | Updates accessor type alias and get_access mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_sub_group_size.cpp | Updates accessor type alias and get_access mode to sycl::access_mode. |
| sycl/test-e2e/EnqueueNativeCommand/custom-command-cuda.cpp | Updates native-command CUDA interop accessors to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/string_test.cpp | Updates device-lib test accessors to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/rand_test.cpp | Updates device-lib test accessor mode to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/math_test.cpp | Updates constexpr access mode variables to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/math_fp64_test.cpp | Updates constexpr access mode variables to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/imf/fp32_test.cpp | Updates constexpr access mode variables to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/cmath_fp64_test.cpp | Updates constexpr access mode variables to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/vector_relational.cpp | Updates built-ins test accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/vector_geometric.cpp | Updates built-ins test accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/scalar_math_2.cpp | Updates built-ins test accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/scalar_geometric.cpp | Updates built-ins test accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/fast-math-flag.cpp | Updates accessor template mode parameters to access_mode. |
| sycl/test-e2e/DeviceLib/bfloat16_conversion_dlopen_test.hpp | Updates constexpr access mode variables to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_subscript.hpp | Updates device_global test accessor mode to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_device_only.hpp | Updates device_global test accessor mode to access_mode. |
| sycl/test-e2e/DeprecatedFeatures/subbuffer_interop.cpp | Updates deprecated-features test accessor modes to access_mode. |
| sycl/test-e2e/Config/kernel_from_file.cpp | Updates accessor mode to access_mode. |
| sycl/test-e2e/Basic/vector/operators.cpp | Updates basic vector test accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/unused_pointer.cpp | Updates basic test accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/subdevice_pi.cpp | Updates basic test accessor mode to access_mode. |
| sycl/test-e2e/Basic/queue/queue_shortcut_functions.cpp | Updates accessor template mode parameters to sycl::access_mode. |
| sycl/test-e2e/Basic/offset-accessor-get_pointer.cpp | Updates constexpr mode value to access_mode. |
| sycl/test-e2e/Basic/multisource.cpp | Updates accessor modes to access_mode. |
| sycl/test-e2e/Basic/multi_ptr.hpp | Updates accessor template mode parameters to access_mode. |
| sycl/test-e2e/Basic/kernel_info.cpp | Updates accessor mode to access_mode. |
| sycl/test-e2e/Basic/interop/make_kernel_subdevice_l0.cpp | Updates accessor mode to access_mode. |
| sycl/test-e2e/Basic/image/image.cpp | Updates constexpr modes and image accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/image/image_trace.cpp | Updates constexpr modes to sycl::access_mode. |
| sycl/test-e2e/Basic/image/image_max_size.cpp | Updates image accessor modes to access_mode. |
| sycl/test-e2e/Basic/image/image_accessor_readwrite.cpp | Updates image/buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/handler/handler_generic_integral_lambda.cpp | Updates accessor type + get_access mode to sycl::access_mode. |
| sycl/test-e2e/Basic/half_builtins.cpp | Updates accessor modes to access_mode. |
| sycl/test-e2e/Basic/get_backend.cpp | Updates accessor mode to access_mode. |
| sycl/test-e2e/Basic/fill_accessor_ur.cpp | Updates accessor modes and accessor type to sycl::access_mode. |
| sycl/test-e2e/Basic/event_profiling_info.cpp | Updates accessor template mode parameters to access_mode. |
| sycl/test-e2e/Basic/compare_exchange_strong.cpp | Updates atomic/write accessor modes to access_mode. |
| sycl/test-e2e/Basic/buffer/subbuffer.cpp | Updates accessor modes to sycl::access_mode and removes an obsolete using line. |
| sycl/test-e2e/Basic/buffer/buffer.cpp | Updates accessor modes (read/write/read_write) to access_mode. |
| sycl/test-e2e/Basic/buffer/buffer_release.cpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/accessor/accessor.cpp | Updates many accessor template parameters to sycl::access_mode across the accessor test. |
| sycl/test-e2e/AtomicRef/sub.h | Updates AtomicRef test accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/min.h | Updates AtomicRef test accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/exchange.h | Updates AtomicRef test accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/atomic_memory_order_acq_rel.cpp | Updates AtomicRef test accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/add.h | Updates AtomicRef test accessor modes to access_mode. |
| sycl/test-e2e/Assert/assert_in_multiple_tus.hpp | Updates accessor mode to sycl::access_mode. |
| sycl/test-e2e/AddressCast/static_address_cast.cpp | Updates accessor modes to sycl::access_mode. |
| sycl/test-e2e/AddressCast/dynamic_address_cast.cpp | Updates accessor modes to sycl::access_mode. |
sarnex
approved these changes
Jul 31, 2026
Contributor
|
lgtm thx |
againull
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
access::mode is deprecated in favor of access_mode.
PR to add deprecations #22803