Skip to content

Fix SPH correction operator lifecycle - #1284

Open
svchb wants to merge 4 commits into
trixi-framework:mainfrom
svchb:fix/correction-operator-lifecycle
Open

Fix SPH correction operator lifecycle#1284
svchb wants to merge 4 commits into
trixi-framework:mainfrom
svchb:fix/correction-operator-lifecycle

Conversation

@svchb

@svchb svchb commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • split correction updates into global density, pressure, boundary, gradient, and surface phases
  • route density, gradient, and force correction roles independently
  • update WCSPH, EDAC, wall, rigid-body, and TLSPH systems through the shared lifecycle
  • ensure correction results are independent of system declaration order
  • split correction tests into focused lifecycle and method files

Scope

This foundation intentionally excludes method-specific numerical hardening and conservative asymmetric pressure changes. Those are isolated in the draft follow-up PRs starting with #1292.

Isolated layer: 16 files, 520 additions, 40 deletions.

Verification

  • complete unit suite passed
  • lifecycle ordering and boundary density/pressure tests passed
  • JuliaFormatter and git diff --check passed

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.67868% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.01%. Comparing base (a720b1d) to head (d855b76).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/general/corrections/common.jl 0.00% 61 Missing ⚠️
...c/schemes/structure/total_lagrangian_sph/system.jl 87.17% 5 Missing ⚠️
.../schemes/boundary/wall_boundary/dummy_particles.jl 91.30% 2 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 94.44% 2 Missing ⚠️
src/general/abstract_system.jl 93.75% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a720b1d) and HEAD (d855b76). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a720b1d) HEAD (d855b76)
total 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1284       +/-   ##
===========================================
- Coverage   90.39%   78.01%   -12.38%     
===========================================
  Files         138      140        +2     
  Lines       11322    11605      +283     
===========================================
- Hits        10234     9054     -1180     
- Misses       1088     2551     +1463     
Flag Coverage Δ
total ?
unit 78.01% <78.67%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
svchb force-pushed the fix/correction-operator-lifecycle branch from 500aaa3 to b06a624 Compare August 16, 2026 13:33
@svchb

svchb commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator Author

Tested locally and reviewed. No performance regression. On 17.8.2026.

@svchb svchb mentioned this pull request Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant