Fix SPH correction operator lifecycle - #1284
Open
svchb wants to merge 4 commits into
Open
Conversation
This was referenced Aug 15, 2026
svchb
marked this pull request as ready for review
August 15, 2026 23:39
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
===========================================
- Coverage 90.39% 78.01% -12.38%
===========================================
Files 138 140 +2
Lines 11322 11605 +283
===========================================
- Hits 10234 9054 -1180
- Misses 1088 2551 +1463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
fix/correction-operator-lifecycle
branch
from
August 16, 2026 13:33
500aaa3 to
b06a624
Compare
This was referenced Aug 16, 2026
Collaborator
Author
|
Tested locally and reviewed. No performance regression. On 17.8.2026. |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This foundation intentionally excludes method-specific numerical hardening and conservative asymmetric pressure changes. Those are isolated in the draft follow-up PRs starting with #1292.
Isolated layer: 16 files, 520 additions, 40 deletions.
Verification
git diff --checkpassed