Skip to content

[eas-build-job] Add local composite function schema - #3928

Merged
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-22387-eas-build-job-local-action-schema
Jul 24, 2026
Merged

[eas-build-job] Add local composite function schema#3928
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-22387-eas-build-job-local-action-schema

Conversation

@sswrk

@sswrk sswrk commented Jul 1, 2026

Copy link
Copy Markdown
Member

Why

First step toward local composite functions for EAS Workflows: reusable step groups referenced via uses: in .eas/workflows/*.yml.

This PR adds the shared contract in @expo/eas-build-job so all consumers agree on composite function config shape.

How

Introduce the composite function config schema in @expo/eas-build-job, the single source of truth for the shape of a function.yml file. No runtime behavior changes yet.

Added:

  • CompositeFunctionConfigZ / CompositeFunctionConfig: Zod schema and type for function.yml (inputs, outputs, runs.steps)
  • CompositeFunctionCatalog: map of normalized path → config

Test Plan

Added unit tests for CompositeFunctionConfigZ.

@linear-code

linear-code Bot commented Jul 1, 2026

Copy link
Copy Markdown

ENG-22387

sswrk commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.13%. Comparing base (a48ad7a) to head (b4397b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3928      +/-   ##
==========================================
+ Coverage   61.12%   61.13%   +0.01%     
==========================================
  Files         970      971       +1     
  Lines       43423    43431       +8     
  Branches     9135     9135              
==========================================
+ Hits        26538    26546       +8     
  Misses      15439    15439              
  Partials     1446     1446              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk added the no changelog PR that doesn't require a changelog entry label Jul 2, 2026
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from ff953ae to 77773ec Compare July 3, 2026 13:43
@sswrk sswrk changed the title [eas-build-job] Add custom action schema and utils [eas-build-job] Add local action schema and utils Jul 3, 2026
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch 4 times, most recently from 85cc322 to 244427d Compare July 3, 2026 15:40
@sswrk sswrk changed the title [eas-build-job] Add local action schema and utils [eas-build-job] Add local action schema Jul 3, 2026
@sswrk
sswrk marked this pull request as ready for review July 3, 2026 15:45
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 244427d to e64f37d Compare July 3, 2026 15:48
@sswrk
sswrk requested a review from sjchmiela July 3, 2026 15:49
Comment thread packages/eas-build-job/src/action.ts Outdated
Comment thread packages/eas-build-job/src/index.ts Outdated
Comment thread packages/eas-build-job/src/action.ts Outdated
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 06676aa to 581492e Compare July 13, 2026 18:08
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch 3 times, most recently from 6c02b08 to b9e22f0 Compare July 16, 2026 10:33
@sswrk sswrk changed the title [eas-build-job] Add local action schema [eas-build-job] Add local composite function schema Jul 17, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve

All specialist reviewers (correctness, consistency, security) returned no findings. The PR introduces only a Zod schema and TypeScript type for composite function configuration with no runtime behavior changes.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from ec3a2b1 to b4397b8 Compare July 24, 2026 11:43
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed. no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants