Skip to content

[steps][3/5] Add action interpolation helpers - #4013

Closed
sswrk wants to merge 1 commit into
szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-timefrom
szymonswierk/eng-22387-steps-action-input-interpolation
Closed

[steps][3/5] Add action interpolation helpers#4013
sswrk wants to merge 1 commit into
szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-timefrom
szymonswierk/eng-22387-steps-action-input-interpolation

Conversation

@sswrk

@sswrk sswrk commented Jul 13, 2026

Copy link
Copy Markdown
Member

Why

Third PR in the @expo/steps local actions stack: small shared helpers for interpolating action-scoped values. Part of ENG-22387.

How

Adds internal actionInterpolation.ts:

  • resolveInterpolatedTarget(target, context, legacyResolver): run ${{ }} via the job interpolator, then route legacy ${ steps.* } through a caller-provided resolver (so action scopes can rewrite short ids)
  • stringifyInterpolatedResult / stringifyOptionalInterpolatedResult
  • containsUnresolvedTemplateReference for deferred template checks

Reuses existing interpolateWithOutputs / BUILD_STEP_OUTPUT_EXPRESSION_REGEXP from template.ts instead of a parallel templateSpans / actionInputs layer. Utilities remain internal (not exported from index.ts).

Test Plan

cd packages/steps && yarn testactionInterpolation unit tests.

@linear-code

linear-code Bot commented Jul 13, 2026

Copy link
Copy Markdown

ENG-22387

sswrk commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@sswrk sswrk changed the title [steps] Add action input interpolation utilities [steps][2/3] Add action input interpolation utilities Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time@b5d4bce). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/steps/src/utils/actionInterpolation.ts 86.37% 3 Missing ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                         @@
##             szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time    #4013   +/-   ##
===================================================================================================
  Coverage                                                                    ?   60.71%           
===================================================================================================
  Files                                                                       ?      961           
  Lines                                                                       ?    42310           
  Branches                                                                    ?     8878           
===================================================================================================
  Hits                                                                        ?    25686           
  Misses                                                                      ?    16529           
  Partials                                                                    ?       95           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk added the no changelog PR that doesn't require a changelog entry label Jul 13, 2026
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from a39d587 to c3c13f2 Compare July 14, 2026 08:56
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 69fbddb to 31fd159 Compare July 14, 2026 08:56
@sswrk sswrk changed the title [steps][2/3] Add action input interpolation utilities [steps][2/3] Harden action input interpolation utilities Jul 14, 2026
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from c3c13f2 to 5d96103 Compare July 14, 2026 12:05
@sswrk sswrk changed the title [steps][2/3] Harden action input interpolation utilities [steps][2/5] Harden action input interpolation utilities Jul 14, 2026
@sswrk sswrk changed the title [steps][2/5] Harden action input interpolation utilities [steps][3/5] Harden action input interpolation utilities Jul 14, 2026
@sswrk
sswrk changed the base branch from szymonswierk/eng-22387-steps-local-action-discovery to graphite-base/4013 July 14, 2026 13:02
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from 5d96103 to 6ac7f96 Compare July 14, 2026 13:02
@sswrk
sswrk changed the base branch from graphite-base/4013 to szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time July 14, 2026 13:02
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 42d3d02 to edafbb2 Compare July 14, 2026 13:25
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from 6ac7f96 to 42ee777 Compare July 14, 2026 13:25
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from edafbb2 to de59447 Compare July 14, 2026 13:35
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from 42ee777 to 30592bd Compare July 14, 2026 13:35
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from de59447 to d1f724c Compare July 14, 2026 13:44
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from 30592bd to ff1c31a Compare July 14, 2026 13:45
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from d1f724c to a0fa166 Compare July 14, 2026 14:12
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from ff1c31a to 4ed949b Compare July 14, 2026 14:12
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from a0fa166 to e49c9b6 Compare July 14, 2026 14:28
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from 7428b06 to 83c2e00 Compare July 14, 2026 14:57
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch 2 times, most recently from 56ea903 to f3e1220 Compare July 14, 2026 16:04
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch 2 times, most recently from 7082ec5 to d5d55e3 Compare July 14, 2026 17:37
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from f3e1220 to 0333696 Compare July 14, 2026 17:37
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch 2 times, most recently from f7b6b57 to 71c9d81 Compare July 15, 2026 12:06
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 062f7d5 to 97bab28 Compare July 15, 2026 12:06
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from 71c9d81 to e804875 Compare July 15, 2026 12:43
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 97bab28 to a9e4e38 Compare July 15, 2026 12:43
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch 3 times, most recently from 071681f to ec4aabd Compare July 15, 2026 14:02
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 7c8b3bc to b5d4bce Compare July 15, 2026 14:02
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from ec4aabd to edac312 Compare July 15, 2026 15:29
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-action-input-interpolation branch from edac312 to 4421a74 Compare July 15, 2026 18:32
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant