Add resumable connect lifecycle framework - #302
Surendra Goutham (is-goutham) merged 11 commits into
Conversation
|
MAJOR: The new Workday lifecycle runner depends on CLI plumbing that does not exist in scripts/flightcheck/cli.py, so the connect flow cannot execute as written.
|
|
The requested plumbing is present in this PR's updated base (#301) and is now propagated into this branch. cli.py defines both --connect-config and --agent-slug; _merge_connect_config overlays the provider JSON and stamps _connectConfigPath; _run_single_checkpoint assigns the selected slug to the runner. tests/flightcheck/test_cli_single_checkpoint.py pins the explicit slug, overlay data, and marker. No additional lifecycle-runner change is needed. |
|
Updated review findings — merge blockers remain
|
|
Re-reviewed the current head (
Also update |
|
Addressed the latest blockers in 0af31a7: connected state and WD-REST-002 are selected-agent scoped, installed dialog identity is resolved from .local/agents while the editable topic remains under workspace, cancellation cannot set actionApplied, and completion reports actual result classes. Validation: 813 targeted tests passed. |
|
Re-reviewed the latest head ( I found no remaining critical blocker. Good to merge. |
The base branch was changed.
…03-connect-lifecycle
|
PR #301 is merged. This PR is retargeted to main, synchronized with the current base, and validated: 855 lifecycle/FlightCheck tests passed. Re-review requested for the current head. |
Summary
Adds a reusable integration lifecycle framework and uses Workday as its first provider:
This is replacement PR 3 of the PR #290 split and is stacked on #301.
Validation
python -m pytest tests/setup/test_connect_lifecycle.py tests/setup/test_setup_router.py tests/scripts/test_checkpoint.py tests/flightcheck/test_cli_single_checkpoint.py -q— 34 passedgit diff --check