Generalize free-surface detection - #1282
Draft
svchb wants to merge 2 commits into
Draft
Conversation
This was referenced Aug 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1282 +/- ##
===========================================
- Coverage 90.39% 79.35% -11.04%
===========================================
Files 138 138
Lines 11322 11490 +168
===========================================
- Hits 10234 9118 -1116
- Misses 1088 2372 +1284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractSurfaceMethodandAbstractSurfaceNormalMethod.ColorfieldSurfaceDetectionand makeColorfieldSurfaceNormalcompute the same activity plus normals.surface_normal_methodtosurface_method; retain deprecated constructor-keyword and accessor compatibility.Breaking change
The system field and primary keyword are renamed for the
0.6.0release. The changelog entry is therefore underVersion 0.6.0.Validation
TRIXIPARTICLES_TEST=unit julia --project=. -e 'using Pkg; Pkg.test()'.\n- Focused surface detection, multicolor, wall/rigid, normal, surface-tension, and interpolation tests pass.\n-git diff --checkpasses.\n\n## Follow-up integration\n\nThe surface-activity consumers in Add smooth Morris interface activity #1269, Add balanced CSS surface tension #1271, Add normal smoothing and VTK diagnostics #1272, Add free-surface tangential shifting #1273, and Add interface-aware tensile instability control #1274 can be rebased onto this shared pipeline.