Skip to content

Generalize free-surface detection - #1282

Draft
svchb wants to merge 2 commits into
trixi-framework:mainfrom
svchb:feature/free-surface-detection
Draft

Generalize free-surface detection#1282
svchb wants to merge 2 commits into
trixi-framework:mainfrom
svchb:feature/free-surface-detection

Conversation

@svchb

@svchb svchb commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Generalize surface geometry behind AbstractSurfaceMethod and AbstractSurfaceNormalMethod.
  • Add activity-only ColorfieldSurfaceDetection and make ColorfieldSurfaceNormal compute the same activity plus normals.
  • Support multicolor fluid interfaces, free surfaces, walls, rigid bodies, interpolation, custom quantities, metadata, and VTK output through one pipeline.
  • Rename surface_normal_method to surface_method; retain deprecated constructor-keyword and accessor compatibility.

Breaking change

The system field and primary keyword are renamed for the 0.6.0 release. The changelog entry is therefore under Version 0.6.0.

Validation

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.45645% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.35%. Comparing base (a720b1d) to head (d23652d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/schemes/fluid/surface_normal_sph.jl 89.04% 16 Missing ⚠️
src/schemes/fluid/fluid.jl 57.14% 6 Missing ⚠️
src/schemes/fluid/surface_tension.jl 0.00% 4 Missing ⚠️
src/general/custom_quantities.jl 62.50% 3 Missing ⚠️
src/schemes/structure/rigid_body/system.jl 50.00% 2 Missing ⚠️
src/general/semidiscretization.jl 75.00% 1 Missing ⚠️
src/io/io.jl 90.90% 1 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 83.33% 1 Missing ⚠️
...chemes/fluid/implicit_incompressible_sph/system.jl 87.50% 1 Missing ⚠️
...rc/schemes/fluid/weakly_compressible_sph/system.jl 88.88% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a720b1d) and HEAD (d23652d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a720b1d) HEAD (d23652d)
total 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1282       +/-   ##
===========================================
- Coverage   90.39%   79.35%   -11.04%     
===========================================
  Files         138      138               
  Lines       11322    11490      +168     
===========================================
- Hits        10234     9118     -1116     
- Misses       1088     2372     +1284     
Flag Coverage Δ
total ?
unit 79.35% <87.45%> (+1.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changes This change will break the public API and requires a new major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant