Clarify and visualize SPH surface normals - #1279
Draft
svchb wants to merge 6 commits into
Draft
Conversation
This was referenced Aug 14, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 90.39% 90.50% +0.10%
==========================================
Files 138 139 +1
Lines 11322 11358 +36
==========================================
+ Hits 10234 10279 +45
+ Misses 1088 1079 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
surface-normals/interface-documentation
branch
from
August 14, 2026 12:44
16c5315 to
335d678
Compare
svchb
force-pushed
the
surface-normals/interface-documentation
branch
from
August 14, 2026 12:52
335d678 to
e347b4c
Compare
svchb
marked this pull request as draft
August 14, 2026 12:56
svchb
force-pushed
the
surface-normals/interface-documentation
branch
from
August 14, 2026 16:04
e347b4c to
02d1689
Compare
Collaborator
Author
|
Coordination note: #1282 now contains the generalized surface-method API, standalone configuration, common documentation, and output plumbing that overlap this draft. After #1282 settles, this PR should be reduced to any still-unique explanation/figures, or closed if those pieces are fully subsumed. No replacement stack layer is planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ColorfieldSurfaceNormalStack
Depends on #1258. Fork branches cannot be selected as bases for pull requests into the upstream repository, so this PR targets
mainand temporarily shows the preceding commit.Review-only diff: svchb/TrixiParticles.jlOpen@surface-tension/akinci-core-hardening...surface-normals/interface-documentation
Verification
Stack Order
Focused merge order:
Supporting views:
All focused PRs target upstream
mainbecause GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.