Add Akinci surface tension support to IISPH - #1267
Draft
svchb wants to merge 15 commits into
Draft
Conversation
This was referenced Aug 8, 2026
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 11:20
c90def9 to
09ee92e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
===========================================
- Coverage 90.39% 79.69% -10.70%
===========================================
Files 138 139 +1
Lines 11322 11581 +259
===========================================
- Hits 10234 9230 -1004
- Misses 1088 2351 +1263
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 12:18
09ee92e to
5fc3355
Compare
This was referenced Aug 14, 2026
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 12:46
5fc3355 to
52b4d2b
Compare
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 12:54
52b4d2b to
45a4d4e
Compare
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 16:04
45a4d4e to
f79308a
Compare
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 16:12
f79308a to
f42b1fa
Compare
svchb
force-pushed
the
surface-tension/akinci-iisph-support
branch
from
August 14, 2026 17:13
f42b1fa to
0e83e06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CohesionForceAkinciandSurfaceTensionAkinciinImplicitIncompressibleSPHSystemAkinciFreeSurfaceCorrectionwith the current IISPH summation densitySurfaceTensionAkincimodel is selectedStack
Depends on #1266, which in turn depends on #1261. Fork branches cannot be selected as bases for pull requests into the upstream repository, so this PR targets
mainand temporarily shows the preceding commits.Review-only diff: svchb/TrixiParticles.jlOpen@surface-tension/akinci-normal-force-normalization...surface-tension/akinci-iisph-support
Verification
git diff --checkpassedStack Order
Supporting views: #1262 is the aggregate implementation view, #1263 is validation, and #1253 is the historical umbrella.
All focused PRs target upstream
mainbecause GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.