Use conservative Akinci pair forces across resolutions - #1266
Draft
svchb wants to merge 14 commits into
Draft
Conversation
This was referenced Aug 8, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
+ Coverage 90.39% 90.54% +0.15%
==========================================
Files 138 139 +1
Lines 11322 11556 +234
==========================================
+ Hits 10234 10463 +229
- Misses 1088 1093 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
surface-tension/akinci-normal-force-normalization
branch
2 times, most recently
from
August 14, 2026 12:18
d31146e to
010429d
Compare
This was referenced Aug 14, 2026
svchb
force-pushed
the
surface-tension/akinci-normal-force-normalization
branch
from
August 14, 2026 12:46
010429d to
4108e86
Compare
svchb
force-pushed
the
surface-tension/akinci-normal-force-normalization
branch
from
August 14, 2026 12:53
4108e86 to
21c513d
Compare
svchb
force-pushed
the
surface-tension/akinci-normal-force-normalization
branch
from
August 14, 2026 16:04
21c513d to
4f4171d
Compare
svchb
force-pushed
the
surface-tension/akinci-normal-force-normalization
branch
from
August 14, 2026 16:12
4f4171d to
f8e5eb3
Compare
svchb
force-pushed
the
surface-tension/akinci-normal-force-normalization
branch
from
August 14, 2026 17:13
f8e5eb3 to
f9af415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
N_i = h_i * n_i2 * m_a * m_b / (m_a + m_b)Stack
Depends on #1261. Fork branches cannot be selected as bases for pull requests into the upstream repository, so this PR targets
mainand temporarily shows the preceding commits.Review-only diff: svchb/TrixiParticles.jlOpen@fix/akinci-free-surface-correction...surface-tension/akinci-normal-force-normalization
Formulation
For raw color gradient
n_i, define the dimensionless Akinci normalN_i = h_i * n_i. The same-material curvature pair force isF_ab = -sigma * (2 * m_a * m_b / (m_a + m_b)) * (N_a - N_b).This reduces to the existing Akinci expression at equal resolution. The minimum pair support ensures that an active pair is present in both directed interaction passes. Coefficient averaging is intentionally not introduced because it would hide unresolved multiphase physics.
Verification
git diff --checkpassedStack Order
Supporting views: #1262 is the aggregate implementation view, #1263 is validation, and #1253 is the historical umbrella.
All focused PRs target upstream
mainbecause GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.