Add dimensionally consistent 2D Akinci kernels - #1259
Draft
svchb wants to merge 9 commits into
Draft
Conversation
svchb
marked this pull request as draft
August 6, 2026 10:42
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 90.39% 90.45% +0.06%
==========================================
Files 138 139 +1
Lines 11322 11446 +124
==========================================
+ Hits 10234 10354 +120
- Misses 1088 1092 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 6, 2026
svchb
force-pushed
the
surface-tension/akinci-2d-kernels
branch
2 times, most recently
from
August 14, 2026 12:17
710db9b to
5aa1b2c
Compare
This was referenced Aug 14, 2026
svchb
force-pushed
the
surface-tension/akinci-2d-kernels
branch
from
August 14, 2026 12:45
5aa1b2c to
04bba70
Compare
svchb
force-pushed
the
surface-tension/akinci-2d-kernels
branch
from
August 14, 2026 12:53
04bba70 to
113745d
Compare
svchb
force-pushed
the
surface-tension/akinci-2d-kernels
branch
from
August 14, 2026 16:04
113745d to
be34e96
Compare
svchb
force-pushed
the
surface-tension/akinci-2d-kernels
branch
from
August 14, 2026 16:12
be34e96 to
07ddec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Depends on #1280. Fork branches cannot be selected as bases for pull requests into the upstream repository, so this PR targets
mainand temporarily shows the preceding commits.Review-only diff: svchb/TrixiParticles.jlOpen@surface-normals/multicolor-thresholds...surface-tension/akinci-2d-kernels
Migration
To preserve an existing 2D pair contribution at compact-support radius
h_c, multiply the previous surface-tension coefficient by627 / (790 * h_c)and the previous adhesion coefficient by42 / (65 * h_c). The resulting pair kernels are resolution-independent at a fixed smoothing-length-to-spacing ratio.Verification
Stack Order
Focused merge order:
Supporting views:
All focused PRs target upstream
mainbecause GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.