Fix Akinci free-surface correction with continuity density - #1261
Draft
svchb wants to merge 13 commits into
Draft
Conversation
svchb
marked this pull request as draft
August 6, 2026 12:16
This was referenced Aug 6, 2026
svchb
force-pushed
the
fix/akinci-free-surface-correction
branch
from
August 8, 2026 18:00
0739e39 to
02edf4c
Compare
This was referenced Aug 8, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 90.39% 90.53% +0.14%
==========================================
Files 138 139 +1
Lines 11322 11546 +224
==========================================
+ Hits 10234 10453 +219
- Misses 1088 1093 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
fix/akinci-free-surface-correction
branch
2 times, most recently
from
August 14, 2026 12:18
ee46340 to
c18d51a
Compare
This was referenced Aug 14, 2026
svchb
force-pushed
the
fix/akinci-free-surface-correction
branch
from
August 14, 2026 12:45
c18d51a to
294fe17
Compare
svchb
force-pushed
the
fix/akinci-free-surface-correction
branch
from
August 14, 2026 12:53
294fe17 to
efb0578
Compare
svchb
force-pushed
the
fix/akinci-free-surface-correction
branch
from
August 14, 2026 16:04
efb0578 to
aca3d92
Compare
svchb
force-pushed
the
fix/akinci-free-surface-correction
branch
from
August 14, 2026 16:12
aca3d92 to
17b313f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AkinciFreeSurfaceCorrectionwhen WCSPH or EDAC usesContinuityDensityAkinciFreeSurfaceCorrectionwhenever the combinedSurfaceTensionAkincimodel is selected, while keeping cohesion-only use independent of normals and correctionStack
Depends on #1259. Fork branches cannot be selected as bases for pull requests into the upstream repository, so this PR targets
mainand temporarily shows the preceding commits.Review-only diff: svchb/TrixiParticles.jlOpen@surface-tension/akinci-2d-kernels...fix/akinci-free-surface-correction
Verification
git diff --checkpassedStack Order
Supporting views: #1262 is the aggregate implementation view, #1263 is validation, and #1253 is the historical umbrella.
All focused PRs target upstream
mainbecause GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.