Skip to content

Draft: integrate focused Akinci surface tension PRs - #1262

Draft
svchb wants to merge 15 commits into
trixi-framework:mainfrom
svchb:integration/akinci-models
Draft

Draft: integrate focused Akinci surface tension PRs#1262
svchb wants to merge 15 commits into
trixi-framework:mainfrom
svchb:integration/akinci-models

Conversation

@svchb

@svchb svchb commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Integration view for the complete focused Akinci implementation stack and base branch for the validation work. This draft does not replace review and merge of the individual focused PRs.

Included Stack

The experimental physical-coefficient model from #1260 is intentionally excluded. Multiphase pair coefficients and pair reference densities remain dedicated future work rather than being represented by a generic average. The aggregate head is identical to #1267; targeting main provides the complete implementation diff.

Follow-Up

Verification

  • complete unit test target passed
  • aggregate surface-tension tests: 182/182
  • IISPH system tests: 155/155
  • reduced validation matrix and all four plotting scripts passed on Add Akinci model shootout with IISPH support #1263
  • JuliaFormatter 2.1.1 and every per-layer git diff --check passed

Stack Order

Focused merge order is #1258, #1279, #1280, #1259, #1261, #1266, then #1267. Supporting views are #1262, #1263, and historical umbrella #1253.

All focused PRs target upstream main because GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.27507% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.62%. Comparing base (a720b1d) to head (0e83e06).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/preprocessing/particle_packing/system.jl 50.00% 3 Missing ⚠️
src/schemes/fluid/surface_normal_sph.jl 92.68% 3 Missing ⚠️
src/schemes/fluid/surface_tension.jl 94.91% 3 Missing ⚠️
src/general/semidiscretization.jl 81.81% 2 Missing ⚠️
src/schemes/fluid/fluid.jl 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   90.39%   90.62%   +0.23%     
==========================================
  Files         138      139       +1     
  Lines       11322    11611     +289     
==========================================
+ Hits        10234    10523     +289     
  Misses       1088     1088              
Flag Coverage Δ
total 90.63% <96.27%> (+0.23%) ⬆️
unit 79.71% <94.26%> (+2.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
svchb force-pushed the integration/akinci-models branch from 5fc3355 to 52b4d2b Compare August 14, 2026 12:46
@svchb
svchb force-pushed the integration/akinci-models branch from 52b4d2b to 45a4d4e Compare August 14, 2026 12:54
@svchb
svchb force-pushed the integration/akinci-models branch from 45a4d4e to f79308a Compare August 14, 2026 16:04
@svchb
svchb force-pushed the integration/akinci-models branch from f79308a to f42b1fa Compare August 14, 2026 16:12
@svchb
svchb force-pushed the integration/akinci-models branch from f42b1fa to 0e83e06 Compare August 14, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant