Skip to content

Surface Tension Prototype V1 - #1253

Draft
svchb wants to merge 109 commits into
trixi-framework:mainfrom
svchb:surface_tension_fix
Draft

Surface Tension Prototype V1 #1253
svchb wants to merge 109 commits into
trixi-framework:mainfrom
svchb:surface_tension_fix

Conversation

@svchb

@svchb svchb commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Status

This draft is the source umbrella for the original surface-tension prototype. Reviewable Akinci work has been rebuilt as a focused, physical-model-free stack directly on upstream main.

Focused Stack

PR #1260 is retired because the experimental physical-coefficient model is not part of the rebuilt stack.

Review Topology

All focused pull requests target upstream main because GitHub cannot use branches from the contributor fork as upstream PR bases. Each stacked PR links a fork comparison that isolates its own layer. As earlier PRs merge, GitHub will automatically remove those commits from later cumulative diffs.

This umbrella remains open as historical context and is not the intended merge path.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.32799% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.85%. Comparing base (76b4882) to head (5dcbffa).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/setups/rectangular_tank.jl 98.34% 5 Missing ⚠️
test/general/custom_quantities.jl 83.33% 5 Missing ⚠️
src/general/initial_condition.jl 66.66% 3 Missing ⚠️
src/preprocessing/geometries/io.jl 57.14% 3 Missing ⚠️
src/preprocessing/geometries/polygon.jl 94.33% 3 Missing ⚠️
src/preprocessing/particle_packing/system.jl 72.72% 3 Missing ⚠️
src/schemes/fluid/fluid.jl 66.66% 3 Missing ⚠️
src/schemes/fluid/surface_tension.jl 84.21% 3 Missing ⚠️
src/setups/rectangular_shape.jl 94.73% 3 Missing ⚠️
test/callbacks/density_reinit.jl 72.72% 3 Missing ⚠️
... and 9 more

❗ There is a different number of reports uploaded between BASE (76b4882) and HEAD (5dcbffa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (76b4882) HEAD (5dcbffa)
total 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1253       +/-   ##
===========================================
- Coverage   90.11%   78.85%   -11.27%     
===========================================
  Files         137      139        +2     
  Lines       10761    11372      +611     
===========================================
- Hits         9697     8967      -730     
- Misses       1064     2405     +1341     
Flag Coverage Δ
total ?
unit 78.85% <94.32%> (+3.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb

svchb commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded as the combined validation base by #1262. The focused implementation remains split across #1258, #1259, #1260, and #1261; this branch is retained as historical source for the still-unextracted experiments.

@svchb svchb closed this Aug 6, 2026
@svchb svchb reopened this Aug 6, 2026
@svchb svchb changed the title Refactor Akinci surface tension foundations Surface Tension Prototype V1 Aug 6, 2026
@svchb

svchb commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Keeping this draft open as the source/umbrella while focused recreation continues. The current extracted sequence is #1258, #1259, #1260, and #1261; #1262 is the clean integration base, and #1263 adds IISPH Akinci support plus the 27-case WCSPH/EDAC/IISPH validation shootout. Remaining experiments from this branch are still to be split out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant