Add Akinci model shootout with IISPH support - #1263
Draft
svchb wants to merge 16 commits into
Draft
Conversation
This was referenced Aug 7, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 90.39% 90.62% +0.23%
==========================================
Files 138 139 +1
Lines 11322 11611 +289
==========================================
+ Hits 10234 10523 +289
Misses 1088 1088
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
validation/akinci-model-shootout
branch
from
August 8, 2026 18:00
3cbbb46 to
f6f4076
Compare
This was referenced Aug 8, 2026
svchb
force-pushed
the
validation/akinci-model-shootout
branch
2 times, most recently
from
August 14, 2026 12:19
98cd0ce to
e3bbc71
Compare
This was referenced Aug 14, 2026
svchb
force-pushed
the
validation/akinci-model-shootout
branch
from
August 14, 2026 12:47
e3bbc71 to
13b8aae
Compare
svchb
force-pushed
the
validation/akinci-model-shootout
branch
from
August 14, 2026 12:54
13b8aae to
ec79d2f
Compare
svchb
force-pushed
the
validation/akinci-model-shootout
branch
from
August 14, 2026 16:04
ec79d2f to
ad32d9b
Compare
svchb
force-pushed
the
validation/akinci-model-shootout
branch
from
August 14, 2026 16:12
ad32d9b to
ff99fda
Compare
svchb
force-pushed
the
validation/akinci-model-shootout
branch
from
August 14, 2026 17:13
ff99fda to
e61e5a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the validation-only layer on top of the focused Akinci implementation collected in #1262.
Changes
4^3,6^3, and8^3particlesStack
Depends on #1262. Fork branches cannot be selected as bases for pull requests into the upstream repository, so this PR targets
mainand temporarily includes the implementation stack.Review-only diff: svchb/TrixiParticles.jlOpen@integration/akinci-models...validation/akinci-model-shootout
Validation Matrix
Models:
CohesionForceAkincias an uncorrected/corrected control across all fourteen configurationsSurfaceTensionAkinciwith its requiredAkinciFreeSurfaceCorrectionacross seven configurationsThe configurations cover WCSPH with continuity or summation density, EDAC with both density calculators and both pressure formulations, and IISPH with summation density.
Verification
2^3and3^3git diff --checkpassedStack Order
Focused merge order is #1258, #1279, #1280, #1259, #1261, #1266, then #1267. Supporting views are #1262, #1263, and historical umbrella #1253.
All focused PRs target upstream
mainbecause GitHub cannot use contributor-fork branches as upstream PR bases. Each PR links a fork comparison that isolates its own review layer.