Stop VF hydrator from ignoring original-tweet verdicts on retweets - #119
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
Closed
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Author
|
Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review. |
Pitchfork-and-Torch
force-pushed
the
fix/vf-retweet-primary-original
branch
from
September 18, 2026 00:36
c959fe8 to
641048d
Compare
Author
|
Rebased onto current xai-org main. Kept primary_vf_id lookup and wired it through upstream visibility_fields so retweet wrappers still inherit the original tweet verdict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Phoenix
VFCandidateHydratorand FollowingVFFollowingCandidateHydratorfetch the retweet original, then stampvisibility_reasonfrom the wrapper id.The original is already in the VF map: For You pushes
retweeted_tweet_idinto the TimelineHome batch; Following pushes it into the same Home batch. Lookup isall_results.get(&candidate.tweet_id).TimelineHome NSFW-high-precision is Interstitial, not Drop.
VFFilteronly hard-dropsAction::Drop.should_drop_ancillaryalso ignores Interstitial. The original verdict never reaches the card.OON retweets are already dropped by
OONRetweetReplyFilter. This path is a followed-user retweet of an interstitial original.VFCandidateHydrator/VFFollowingCandidateHydrator(both already fetch the original)visibility_reasonforwarded on the scored post (scored_posts_server.rs);VFFilterkeeps Interstitialtweet_idinstead ofretweeted_tweet_id.unwrap_or(tweet_id)AdsBrandSafetyVfHydratorprimary_id is alreadyretweeted_tweet_id.unwrap_or(tweet_id)This is not PR 55 / 90 (Home vs Recs merge). This is not PR 115 (Following quotes at Recs). This is not PR 116 (OON RT originals at Recs; those wrappers are dropped before VF). This is not PR 118 (QuoteHydrator TES key).
Fix
Look up the primary VF verdict with
primary_vf_id= original tweet id. Native posts unchanged. Ancillary Drop on the original is unchanged.Tests
cargo: cannot run. Public dump has no Home Mixer manifest.